[Bast-commits] r3626 - in DBIx-Class/0.08/branches/jdbicompat: . lib/DBIx/Class/Storage/DBI

[jesse at dev.catalyst.perl.org]

Author: jesse
Date: 2007-07-29 02:05:06 +0100 (Sun, 29 Jul 2007)
New Revision: 3626

Modified:
   DBIx-Class/0.08/branches/jdbicompat/
   DBIx-Class/0.08/branches/jdbicompat/lib/DBIx/Class/Storage/DBI/Pg.pm
Log:
 r64894 at pinglin:  jesse | 2007-07-28 17:33:17 -0500
 * Perldoc updates - mst check me?
 * Added a note about a regexp that's more robust in JDBI and may want stealing



Property changes on: DBIx-Class/0.08/branches/jdbicompat
___________________________________________________________________
Name: svk:merge
   - 0ff1c2e0-7480-4c26-9844-d5e952dc0eb0:/local/dbic-jdbi:64893
168d5346-440b-0410-b799-f706be625ff1:/DBIx-Class-current:2207
462d4d0c-b505-0410-bf8e-ce8f877b3390:/local/bast/DBIx-Class:3159
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/DBIx-Class/0.08/trunk:3607
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class-C3:318
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class-current:2222
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class-joins:173
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class-resultset:570
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/datetime:1716
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/find_compat:1855
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/find_unique_query_fixes:2142
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/inflate:1988
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/many_to_many:2025
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/re_refactor_bugfix:1944
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/reorganize_tests:1827
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/resultset-new-refactor:1766
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/resultset_2_electric_boogaloo:2175
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/resultset_cleanup:2102
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/sqlt_tests_refactor:2043
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/trunk/DBIx-Class:3606
   + 0ff1c2e0-7480-4c26-9844-d5e952dc0eb0:/local/dbic-jdbi:64894
168d5346-440b-0410-b799-f706be625ff1:/DBIx-Class-current:2207
462d4d0c-b505-0410-bf8e-ce8f877b3390:/local/bast/DBIx-Class:3159
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/DBIx-Class/0.08/trunk:3607
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class-C3:318
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class-current:2222
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class-joins:173
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class-resultset:570
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/datetime:1716
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/find_compat:1855
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/find_unique_query_fixes:2142
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/inflate:1988
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/many_to_many:2025
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/re_refactor_bugfix:1944
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/reorganize_tests:1827
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/resultset-new-refactor:1766
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/resultset_2_electric_boogaloo:2175
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/resultset_cleanup:2102
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/sqlt_tests_refactor:2043
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/trunk/DBIx-Class:3606

Modified: DBIx-Class/0.08/branches/jdbicompat/lib/DBIx/Class/Storage/DBI/Pg.pm
===================================================================
--- DBIx-Class/0.08/branches/jdbicompat/lib/DBIx/Class/Storage/DBI/Pg.pm	2007-07-29 01:04:51 UTC (rev 3625)
+++ DBIx-Class/0.08/branches/jdbicompat/lib/DBIx/Class/Storage/DBI/Pg.pm	2007-07-29 01:05:06 UTC (rev 3626)
@@ -34,6 +34,8 @@
     my $info = $dbh->column_info(undef,$schema,$table,$col)->fetchrow_hashref;
     if(defined $info->{COLUMN_DEF} and
        $info->{COLUMN_DEF} =~ /^nextval\(+'([^']+)'::(?:text|regclass)\)/) {
+        # XXX TODO if this doesn't work, check the slightly different regex in Jifty::DBI::Handle::Pg
+        # to catch possible different quoting
       my $seq = $1;
       # may need to strip quotes -- see if this works
       return $seq =~ /\./ ? $seq : $info->{TABLE_SCHEM} . "." . $seq;
@@ -88,8 +90,16 @@
 
 =head1 DESCRIPTION
 
-This class implements autoincrements for PostgreSQL.
+This class implements a custom database profile for PostgreSQL, including
 
+=over
+
+=item autoincrement support
+
+=item bind attribute handling (for blobs)
+
+=item a pointer to the correct date parser
+
 =head1 AUTHORS
 
 Marcus Ramberg <m.ramberg at cpan.org>