[Bast-commits] r3629 - in DBIx-Class/0.08/branches/jdbicompat: . lib/DBIx/Class/JDBICompat

[jesse at dev.catalyst.perl.org]

Author: jesse
Date: 2007-07-29 02:05:42 +0100 (Sun, 29 Jul 2007)
New Revision: 3629

Modified:
   DBIx-Class/0.08/branches/jdbicompat/
   DBIx-Class/0.08/branches/jdbicompat/lib/DBIx/Class/JDBICompat/Record.pm
Log:
 r64897 at pinglin:  jesse | 2007-07-28 17:35:06 -0500
 * Removed JDBICompat::Record's bind_params support since it should be handled at the DBIC layer
 * Removed warnings



Property changes on: DBIx-Class/0.08/branches/jdbicompat
___________________________________________________________________
Name: svk:merge
   - 0ff1c2e0-7480-4c26-9844-d5e952dc0eb0:/local/dbic-jdbi:64896
168d5346-440b-0410-b799-f706be625ff1:/DBIx-Class-current:2207
462d4d0c-b505-0410-bf8e-ce8f877b3390:/local/bast/DBIx-Class:3159
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/DBIx-Class/0.08/trunk:3607
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class-C3:318
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class-current:2222
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class-joins:173
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class-resultset:570
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/datetime:1716
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/find_compat:1855
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/find_unique_query_fixes:2142
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/inflate:1988
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/many_to_many:2025
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/re_refactor_bugfix:1944
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/reorganize_tests:1827
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/resultset-new-refactor:1766
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/resultset_2_electric_boogaloo:2175
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/resultset_cleanup:2102
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/sqlt_tests_refactor:2043
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/trunk/DBIx-Class:3606
   + 0ff1c2e0-7480-4c26-9844-d5e952dc0eb0:/local/dbic-jdbi:64897
168d5346-440b-0410-b799-f706be625ff1:/DBIx-Class-current:2207
462d4d0c-b505-0410-bf8e-ce8f877b3390:/local/bast/DBIx-Class:3159
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/DBIx-Class/0.08/trunk:3607
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class-C3:318
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class-current:2222
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class-joins:173
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class-resultset:570
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/datetime:1716
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/find_compat:1855
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/find_unique_query_fixes:2142
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/inflate:1988
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/many_to_many:2025
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/re_refactor_bugfix:1944
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/reorganize_tests:1827
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/resultset-new-refactor:1766
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/resultset_2_electric_boogaloo:2175
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/resultset_cleanup:2102
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/branches/DBIx-Class/sqlt_tests_refactor:2043
bd8105ee-0ff8-0310-8827-fb3f25b6796d:/trunk/DBIx-Class:3606

Modified: DBIx-Class/0.08/branches/jdbicompat/lib/DBIx/Class/JDBICompat/Record.pm
===================================================================
--- DBIx-Class/0.08/branches/jdbicompat/lib/DBIx/Class/JDBICompat/Record.pm	2007-07-29 01:05:30 UTC (rev 3628)
+++ DBIx-Class/0.08/branches/jdbicompat/lib/DBIx/Class/JDBICompat/Record.pm	2007-07-29 01:05:42 UTC (rev 3629)
@@ -1111,7 +1111,7 @@
 
 This method is called after attempting to insert the record into the
 database. It gets handed a reference to the return value of the
-insert. That'll either be a true value or a L<Class::ReturnValue>
+insert. That will either be a true value or a L<Class::ReturnValue>
 
 =back
 
@@ -1136,8 +1136,7 @@
 
     my $ret = $self->__create(%attribs);
 
-    $ok = $self->_run_callback( name => "after_create",
-                           args => \$ret);
+    $ok = $self->_run_callback( name => "after_create", args => \$ret);
     return $ok if (not defined $ok);
     
     if ($class) {
@@ -1169,13 +1168,11 @@
                 'Jifty::DBI::Record' );
         }
 
-        warn "Before running fitlers my value is ".$attribs{$column_name};
         $self->_apply_input_filters(
             column    => $column,
             value_ref => \$attribs{$column_name},
         );
 
-        warn "After running fitlers my value is ".$attribs{$column_name};
 
         # Implement 'is distinct' checking
         if ( $column->distinct ) {
@@ -1186,11 +1183,6 @@
             }
         }
 
-        if ( $column->type =~ /^(text|longtext|clob|blob|lob|bytea)$/i ) {
-            my $bhash = $self->_handle->blob_params( $column_name, $column->type );
-            $bhash->{'value'} = $attribs{$column_name};
-            $attribs{$column_name} = $bhash;
-        }
     }
 
     for my $column ($self->columns) {