[Bast-commits] r3633 - DBIx-Class/0.08/branches/jdbicompat/lib/DBIx/Class/JDBICompat

[matthewt at dev.catalyst.perl.org]

Author: matthewt
Date: 2007-07-29 19:26:43 +0100 (Sun, 29 Jul 2007)
New Revision: 3633

Modified:
   DBIx-Class/0.08/branches/jdbicompat/lib/DBIx/Class/JDBICompat/Handle.pm
Log:
clarified last_insert_id usage

Modified: DBIx-Class/0.08/branches/jdbicompat/lib/DBIx/Class/JDBICompat/Handle.pm
===================================================================
--- DBIx-Class/0.08/branches/jdbicompat/lib/DBIx/Class/JDBICompat/Handle.pm	2007-07-29 18:22:01 UTC (rev 3632)
+++ DBIx-Class/0.08/branches/jdbicompat/lib/DBIx/Class/JDBICompat/Handle.pm	2007-07-29 18:26:43 UTC (rev 3633)
@@ -338,7 +338,12 @@
         warn $@;
         return undef;
     }
-    return $storage->last_insert_id($source, 'id'); # XXX TODO. HARDCODED THE ID. CAN WE NOT GET THIS FROM THE $source?
+    return $storage->last_insert_id($source, 'id'); # XXX TODO. HARDCODED THE ID. SEE BELOW.
+    # we can get this from the source, but you'll end up re-implementing the
+    # logic currently embedded in Row's insert method. Factoring this out would
+    # probably be ok, but I figure we'll probably move Record over to using
+    # the Row code or something before that so fine for now? (maybe post-09
+    # when this stuff is encapulated in source entirely is good?)
 }
 
 =head2 update_record_value