[Bast-commits] r3516 - trunk/DBIx-Class/lib/DBIx/Class/PK

[matthewt at dev.catalyst.perl.org]

Author: matthewt
Date: 2007-06-20 05:00:54 +0100 (Wed, 20 Jun 2007)
New Revision: 3516

Modified:
   trunk/DBIx-Class/lib/DBIx/Class/PK/Auto.pm
Log:
eleiminate vestigial code in PK::Auto

Modified: trunk/DBIx-Class/lib/DBIx/Class/PK/Auto.pm
===================================================================
--- trunk/DBIx-Class/lib/DBIx/Class/PK/Auto.pm	2007-06-20 04:00:03 UTC (rev 3515)
+++ trunk/DBIx-Class/lib/DBIx/Class/PK/Auto.pm	2007-06-20 04:00:54 UTC (rev 3516)
@@ -11,7 +11,7 @@
 
 =head1 SYNOPSIS
 
-__PACKAGE__->load_components(qw/PK::Auto Core/);
+__PACKAGE__->load_components(qw/Core/);
 __PACKAGE__->set_primary_key('id');
 
 =head1 DESCRIPTION
@@ -19,9 +19,10 @@
 This class overrides the insert method to get automatically incremented primary
 keys.
 
-  __PACKAGE__->load_components(qw/PK::Auto Core/);
+  __PACKAGE__->load_components(qw/Core/);
 
-Note that C<PK::Auto> is specified as the left of the Core component.
+PK::Auto is now part of Core.
+
 See L<DBIx::Class::Manual::Component> for details of component interactions.
 
 =head1 LOGIC
@@ -33,31 +34,8 @@
 
 =head2 insert
 
-Overrides C<insert> so that it will get the value of autoincremented primary
-keys.
+The code that was handled here is now in Row for efficiency.
 
-=cut
-
-sub insert {
-  my ($self, @rest) = @_;
-  my $ret = $self->next::method(@rest);
-
-  my ($pri, $too_many) = grep { !defined $self->get_column($_) || 
-                                    ref($self->get_column($_)) eq 'SCALAR'} $self->primary_columns;
-  return $ret unless defined $pri; # if all primaries are already populated, skip auto-inc
-  $self->throw_exception( "More than one possible key found for auto-inc on ".ref $self )
-    if defined $too_many;
-
-  my $storage = $self->result_source->storage;
-  $self->throw_exception( "Missing primary key but Storage doesn't support last_insert_id" )
-    unless $storage->can('last_insert_id');
-  my $id = $storage->last_insert_id($self->result_source,$pri);
-  $self->throw_exception( "Can't get last insert id" ) unless $id;
-  $self->store_column($pri => $id);
-
-  return $ret;
-}
-
 =head2 sequence
 
 Manually define the correct sequence for your table, to avoid the overhead