[Bast-commits] r3154 - in
branches/DBIx-Class-Schema-Loader/current: .
lib/DBIx/Class/Schema/Loader lib/DBIx/Class/Schema/Loader/DBI
blblack at dev.catalyst.perl.org
blblack at dev.catalyst.perl.org
Thu Mar 29 23:20:14 GMT 2007
Author: blblack
Date: 2007-03-29 23:20:10 +0100 (Thu, 29 Mar 2007)
New Revision: 3154
Modified:
branches/DBIx-Class-Schema-Loader/current/Changes
branches/DBIx-Class-Schema-Loader/current/lib/DBIx/Class/Schema/Loader/DBI.pm
branches/DBIx-Class-Schema-Loader/current/lib/DBIx/Class/Schema/Loader/DBI/Pg.pm
Log:
statistics_info support
Modified: branches/DBIx-Class-Schema-Loader/current/Changes
===================================================================
--- branches/DBIx-Class-Schema-Loader/current/Changes 2007-03-29 14:13:17 UTC (rev 3153)
+++ branches/DBIx-Class-Schema-Loader/current/Changes 2007-03-29 22:20:10 UTC (rev 3154)
@@ -1,5 +1,8 @@
Revision history for Perl extension DBIx::Class::Schema::Loader
+ - Added support for DBI's new standard "statistics_info"
+ method to gather unique key info (only supported by
+ DBD::Pg trunk + DBI >= 1.52 so far)
- columns_info_for imported from DBIx::Class
- relationships are now on by default, use skip_relationships
to disable them
Modified: branches/DBIx-Class-Schema-Loader/current/lib/DBIx/Class/Schema/Loader/DBI/Pg.pm
===================================================================
--- branches/DBIx-Class-Schema-Loader/current/lib/DBIx/Class/Schema/Loader/DBI/Pg.pm 2007-03-29 14:13:17 UTC (rev 3153)
+++ branches/DBIx-Class-Schema-Loader/current/lib/DBIx/Class/Schema/Loader/DBI/Pg.pm 2007-03-29 22:20:10 UTC (rev 3154)
@@ -38,6 +38,11 @@
sub _table_uniq_info {
my ($self, $table) = @_;
+ # Use the default support if available
+ return $self->next::method($table)
+ if $DBI::VERSION >= 1.52
+ && $DBD::Pg::VERSION >= 1.50;
+
my @uniqs;
my $dbh = $self->schema->storage->dbh;
Modified: branches/DBIx-Class-Schema-Loader/current/lib/DBIx/Class/Schema/Loader/DBI.pm
===================================================================
--- branches/DBIx-Class-Schema-Loader/current/lib/DBIx/Class/Schema/Loader/DBI.pm 2007-03-29 14:13:17 UTC (rev 3153)
+++ branches/DBIx-Class-Schema-Loader/current/lib/DBIx/Class/Schema/Loader/DBI.pm 2007-03-29 22:20:10 UTC (rev 3154)
@@ -114,7 +114,7 @@
# Returns arrayref of pk col names
sub _table_pk_info {
- my ( $self, $table ) = @_;
+ my ($self, $table) = @_;
my $dbh = $self->schema->storage->dbh;
@@ -124,10 +124,40 @@
return \@primary;
}
-# Override this for uniq info
+# Override this for vendor-specific uniq info
sub _table_uniq_info {
- warn "No UNIQUE constraint information can be gathered for this vendor";
- return [];
+ my ($self, $table) = @_;
+
+ my $dbh = $self->schema->storage->dbh;
+ if(!$dbh->can('statistics_info')) {
+ warn "No UNIQUE constraint information can be gathered for this vendor";
+ return [];
+ }
+
+ my %indices;
+ my $sth = $dbh->statistics_info(undef, $self->db_schema, $table, 1, 1);
+ while(my $row = $sth->fetchrow_hashref) {
+ # skip table-level stats, conditional indexes, and any index missing
+ # critical fields
+ next if $row->{TYPE} eq 'table'
+ || defined $row->{FILTER_CONDITION}
+ || !$row->{INDEX_NAME}
+ || !defined $row->{ORDINAL_POSITION}
+ || !$row->{COLUMN_NAME};
+
+ $indices{$row->{INDEX_NAME}}->{$row->{ORDINAL_POSITION}} = $row->{COLUMN_NAME};
+ }
+
+ my @retval;
+ foreach my $index_name (keys %indices) {
+ my $index = $indices{$index_name};
+ push(@retval, [ $index_name => [
+ map { $index->{$_} }
+ sort keys %$index
+ ]]);
+ }
+
+ return \@retval;
}
# Find relationships
More information about the Bast-commits
mailing list