[Bast-commits] r3434 - in trunk/DBIx-Class-InflateColumn-ISBN: . lib/DBIx/Class/InflateColumn t

[penguin at dev.catalyst.perl.org]

Author: penguin
Date: 2007-05-29 20:06:05 +0100 (Tue, 29 May 2007)
New Revision: 3434

Modified:
   trunk/DBIx-Class-InflateColumn-ISBN/Changes
   trunk/DBIx-Class-InflateColumn-ISBN/Makefile.PL
   trunk/DBIx-Class-InflateColumn-ISBN/README
   trunk/DBIx-Class-InflateColumn-ISBN/TODO
   trunk/DBIx-Class-InflateColumn-ISBN/lib/DBIx/Class/InflateColumn/ISBN.pm
   trunk/DBIx-Class-InflateColumn-ISBN/t/01-isbn.t
Log:
DBIC::InflateColumn::ISBN test fixeS

Modified: trunk/DBIx-Class-InflateColumn-ISBN/Changes
===================================================================
--- trunk/DBIx-Class-InflateColumn-ISBN/Changes	2007-05-29 18:04:38 UTC (rev 3433)
+++ trunk/DBIx-Class-InflateColumn-ISBN/Changes	2007-05-29 19:06:05 UTC (rev 3434)
@@ -1,6 +1,9 @@
 Revision history for DBIx::Class::InflateColumn::ISBN
 
+0.03000 Tue May 29 17:50:28 2007
+    - Tweaked Makefile.PL and TODO files.
     - Nuked warnings from the tests.
+    - Added workaround for 'validation error checked' test.
 
 0.02000 Fri May 25 15:41:44 2007
     - Started using longer version numbers.

Modified: trunk/DBIx-Class-InflateColumn-ISBN/Makefile.PL
===================================================================
--- trunk/DBIx-Class-InflateColumn-ISBN/Makefile.PL	2007-05-29 18:04:38 UTC (rev 3433)
+++ trunk/DBIx-Class-InflateColumn-ISBN/Makefile.PL	2007-05-29 19:06:05 UTC (rev 3434)
@@ -11,7 +11,7 @@
 requires 'Business::ISBN' => 1.82;
 
 tests 't/*.t';
-clean_files 'DBIx-Class-InflateColumn-ISBN-* t/var';
+clean_files 'DBIx-Class-InflateColumn-ISBN-* Makefile inc META.yml';
 
 eval {
     system 'pod2text lib/DBIx/Class/InflateColumn/ISBN.pm > README';

Modified: trunk/DBIx-Class-InflateColumn-ISBN/README
===================================================================
--- trunk/DBIx-Class-InflateColumn-ISBN/README	2007-05-29 18:04:38 UTC (rev 3433)
+++ trunk/DBIx-Class-InflateColumn-ISBN/README	2007-05-29 19:06:05 UTC (rev 3434)
@@ -3,7 +3,7 @@
     from columns.
 
 VERSION
-    Version 0.02000
+    Version 0.03000
 
 SYNOPSIS
     Load this component and declare columns as ISBNs with the appropriate

Modified: trunk/DBIx-Class-InflateColumn-ISBN/TODO
===================================================================
--- trunk/DBIx-Class-InflateColumn-ISBN/TODO	2007-05-29 18:04:38 UTC (rev 3433)
+++ trunk/DBIx-Class-InflateColumn-ISBN/TODO	2007-05-29 19:06:05 UTC (rev 3434)
@@ -1 +1,5 @@
-EVERYTHING
+- Allow the option of storing ISBNs in the database with hyphens?
+
+- Add a warning when trying to inflate ISBNs with an invalid checksum?
+
+- Other things I haven't thought of yet.

Modified: trunk/DBIx-Class-InflateColumn-ISBN/lib/DBIx/Class/InflateColumn/ISBN.pm
===================================================================
--- trunk/DBIx-Class-InflateColumn-ISBN/lib/DBIx/Class/InflateColumn/ISBN.pm	2007-05-29 18:04:38 UTC (rev 3433)
+++ trunk/DBIx-Class-InflateColumn-ISBN/lib/DBIx/Class/InflateColumn/ISBN.pm	2007-05-29 19:06:05 UTC (rev 3434)
@@ -3,7 +3,7 @@
 use warnings;
 use strict;
 
-our $VERSION = '0.02000';
+our $VERSION = '0.03000';
 
 use base qw/DBIx::Class/;
 __PACKAGE__->mk_classdata('isbn_class');
@@ -15,7 +15,7 @@
 
 =head1 VERSION
 
-Version 0.02000
+Version 0.03000
 
 =head1 SYNOPSIS
 

Modified: trunk/DBIx-Class-InflateColumn-ISBN/t/01-isbn.t
===================================================================
--- trunk/DBIx-Class-InflateColumn-ISBN/t/01-isbn.t	2007-05-29 18:04:38 UTC (rev 3433)
+++ trunk/DBIx-Class-InflateColumn-ISBN/t/01-isbn.t	2007-05-29 19:06:05 UTC (rev 3434)
@@ -56,7 +56,11 @@
 my $host = $rs->create({ book => 'Elementary Mechanics', isbn => $isbn });
 isa_ok($host, 'DBICTest::Library', 'create with object');
 is($host->get_column('isbn'), $isbn->isbn, 'code with X correctly deflated');
-is($host->isbn->is_valid_checksum, Business::ISBN::BAD_CHECKSUM, 'validation error checked');
+if ($Business::ISBN::VERSION eq '2.00_01') {
+    is($host->isbn->is_valid_checksum, Business::ISBN::BAD_CHECKSUM, 'validation error checked');
+} else {
+    is($host->isbn->is_valid_checksum, Business::ISBN::BAD_ISBN, 'validation error checked');
+}
 
 #$isbn = Business::ISBN->new('foobar');
 #eval { $book = $rs->create({ book => 'foobar', isbn => $isbn }); };