[Bast-commits] r3440 - in trunk/DBIx-Class-InflateColumn-ISBN: . t t/var

penguin at dev.catalyst.perl.org penguin at dev.catalyst.perl.org
Wed May 30 13:01:22 GMT 2007


Author: penguin
Date: 2007-05-30 13:01:21 +0100 (Wed, 30 May 2007)
New Revision: 3440

Modified:
   trunk/DBIx-Class-InflateColumn-ISBN/Changes
   trunk/DBIx-Class-InflateColumn-ISBN/t/01-isbn.t
   trunk/DBIx-Class-InflateColumn-ISBN/t/var/test.db
Log:
Minor DBIC::IC::ISBN tweak.

Modified: trunk/DBIx-Class-InflateColumn-ISBN/Changes
===================================================================
--- trunk/DBIx-Class-InflateColumn-ISBN/Changes	2007-05-30 11:31:47 UTC (rev 3439)
+++ trunk/DBIx-Class-InflateColumn-ISBN/Changes	2007-05-30 12:01:21 UTC (rev 3440)
@@ -1,5 +1,8 @@
 Revision history for DBIx::Class::InflateColumn::ISBN
 
+    - Fixed 'validation error checked' test to work for future
+      versions of Business::ISBN.
+
 0.03000 Tue May 29 17:50:28 2007
     - Tweaked Makefile.PL and TODO files.
     - Nuked warnings from the tests.

Modified: trunk/DBIx-Class-InflateColumn-ISBN/t/01-isbn.t
===================================================================
--- trunk/DBIx-Class-InflateColumn-ISBN/t/01-isbn.t	2007-05-30 11:31:47 UTC (rev 3439)
+++ trunk/DBIx-Class-InflateColumn-ISBN/t/01-isbn.t	2007-05-30 12:01:21 UTC (rev 3440)
@@ -56,11 +56,7 @@
 my $host = $rs->create({ book => 'Elementary Mechanics', isbn => $isbn });
 isa_ok($host, 'DBICTest::Library', 'create with object');
 is($host->get_column('isbn'), $isbn->isbn, 'code with X correctly deflated');
-if ($Business::ISBN::VERSION eq '2.00_01') {
-    is($host->isbn->is_valid_checksum, Business::ISBN::BAD_CHECKSUM, 'validation error checked');
-} else {
-    is($host->isbn->is_valid_checksum, Business::ISBN::BAD_ISBN, 'validation error checked');
-}
+isnt($host->isbn->is_valid_checksum, Business::ISBN::GOOD_ISBN, 'validation error checked');
 
 #$isbn = Business::ISBN->new('foobar');
 #eval { $book = $rs->create({ book => 'foobar', isbn => $isbn }); };

Modified: trunk/DBIx-Class-InflateColumn-ISBN/t/var/test.db
===================================================================
(Binary files differ)




More information about the Bast-commits mailing list