[Bast-commits] r3821 - DBIx-Class/0.08/trunk/lib/DBIx/Class

[nigel at dev.catalyst.perl.org]

Author: nigel
Date: 2007-10-17 16:59:12 +0100 (Wed, 17 Oct 2007)
New Revision: 3821

Modified:
   DBIx-Class/0.08/trunk/lib/DBIx/Class/ResultSet.pm
   DBIx-Class/0.08/trunk/lib/DBIx/Class/ResultSourceHandle.pm
Log:
Added reference to RH perl bug at appropriate points

Modified: DBIx-Class/0.08/trunk/lib/DBIx/Class/ResultSet.pm
===================================================================
--- DBIx-Class/0.08/trunk/lib/DBIx/Class/ResultSet.pm	2007-10-14 22:33:47 UTC (rev 3820)
+++ DBIx-Class/0.08/trunk/lib/DBIx/Class/ResultSet.pm	2007-10-17 15:59:12 UTC (rev 3821)
@@ -95,6 +95,8 @@
 
   $attrs->{alias} ||= 'me';
 
+  # Creation of {} and bless separated to mitigate RH perl bug
+  # see https://bugzilla.redhat.com/show_bug.cgi?id=196836
   my $self = {
     _source_handle => $source,
     result_class => $attrs->{result_class} || $source->resolve->result_class,

Modified: DBIx-Class/0.08/trunk/lib/DBIx/Class/ResultSourceHandle.pm
===================================================================
--- DBIx-Class/0.08/trunk/lib/DBIx/Class/ResultSourceHandle.pm	2007-10-14 22:33:47 UTC (rev 3820)
+++ DBIx-Class/0.08/trunk/lib/DBIx/Class/ResultSourceHandle.pm	2007-10-17 15:59:12 UTC (rev 3821)
@@ -7,6 +7,8 @@
 use base qw/DBIx::Class/;
 
 use overload
+    # on some RH perls the following line causes serious performance problem
+    # see https://bugzilla.redhat.com/show_bug.cgi?id=196836
     q/""/ => sub { __PACKAGE__ . ":" . shift->source_moniker; },
     fallback => 1;