[Bast-commits] r4457 - in trunk/Devel-REPL: . lib/Devel/REPL/Plugin lib/Devel/REPL/Plugin/B lib/Devel/REPL/Plugin/CompletionDriver

Sartak at dev.catalyst.perl.org Sartak at dev.catalyst.perl.org
Mon Jun 2 21:02:06 BST 2008


Author: Sartak
Date: 2008-06-02 21:02:05 +0100 (Mon, 02 Jun 2008)
New Revision: 4457

Modified:
   trunk/Devel-REPL/
   trunk/Devel-REPL/lib/Devel/REPL/Plugin/B/Concise.pm
   trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/Globals.pm
   trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/INC.pm
   trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/Keywords.pm
   trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/LexEnv.pm
   trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/Methods.pm
   trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/Turtles.pm
   trunk/Devel-REPL/lib/Devel/REPL/Plugin/LexEnv.pm
   trunk/Devel-REPL/lib/Devel/REPL/Plugin/Nopaste.pm
   trunk/Devel-REPL/lib/Devel/REPL/Plugin/PPI.pm
   trunk/Devel-REPL/lib/Devel/REPL/Plugin/Peek.pm
Log:
 r61423 at onn:  sartak | 2008-06-02 16:00:33 -0400
 Use "BEFORE_PLUGIN { load_plugin }" instead of "with"



Property changes on: trunk/Devel-REPL
___________________________________________________________________
Name: svk:merge
   - 08e7d58d-de06-4458-8c15-335e402ab116:/local/Devel-REPL:61346
6d2a1d83-d666-409f-9dbf-d3bfcf4e9009:/local/bast/broken_internets/Devel-REPL:80567
   + 08e7d58d-de06-4458-8c15-335e402ab116:/local/Devel-REPL:61423
6d2a1d83-d666-409f-9dbf-d3bfcf4e9009:/local/bast/broken_internets/Devel-REPL:80567

Modified: trunk/Devel-REPL/lib/Devel/REPL/Plugin/B/Concise.pm
===================================================================
--- trunk/Devel-REPL/lib/Devel/REPL/Plugin/B/Concise.pm	2008-06-02 18:46:12 UTC (rev 4456)
+++ trunk/Devel-REPL/lib/Devel/REPL/Plugin/B/Concise.pm	2008-06-02 20:02:05 UTC (rev 4457)
@@ -9,7 +9,10 @@
 
 use namespace::clean -except => [ 'meta' ];
 
-with qw(Devel::REPL::Plugin::Turtles);
+sub BEFORE_PLUGIN {
+    my $self = shift;
+    $self->load_plugin('Turtles');
+}
 
 sub AFTER_PLUGIN {
   my $self = shift;

Modified: trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/Globals.pm
===================================================================
--- trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/Globals.pm	2008-06-02 18:46:12 UTC (rev 4456)
+++ trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/Globals.pm	2008-06-02 20:02:05 UTC (rev 4457)
@@ -2,10 +2,6 @@
 use Devel::REPL::Plugin;
 use namespace::clean -except => [ 'meta' ];
 
-with qw(
-  Devel::REPL::Plugin::Completion
-);
-
 around complete => sub {
   my $orig = shift;
   my ($self, $text, $document) = @_;

Modified: trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/INC.pm
===================================================================
--- trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/INC.pm	2008-06-02 18:46:12 UTC (rev 4456)
+++ trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/INC.pm	2008-06-02 20:02:05 UTC (rev 4457)
@@ -4,9 +4,10 @@
 use File::Spec;
 use namespace::clean -except => [ 'meta' ];
 
-with qw(
-  Devel::REPL::Plugin::Completion
-);
+sub BEFORE_PLUGIN {
+    my $self = shift;
+    $self->load_plugin('Completion');
+}
 
 around complete => sub {
   my $orig = shift;

Modified: trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/Keywords.pm
===================================================================
--- trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/Keywords.pm	2008-06-02 18:46:12 UTC (rev 4456)
+++ trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/Keywords.pm	2008-06-02 20:02:05 UTC (rev 4457)
@@ -3,9 +3,10 @@
 use B::Keywords qw/@Functions @Barewords/;
 use namespace::clean -except => [ 'meta' ];
 
-with qw(
-  Devel::REPL::Plugin::Completion
-);
+sub BEFORE_PLUGIN {
+    my $self = shift;
+    $self->load_plugin('Completion');
+}
 
 around complete => sub {
   my $orig = shift;

Modified: trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/LexEnv.pm
===================================================================
--- trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/LexEnv.pm	2008-06-02 18:46:12 UTC (rev 4456)
+++ trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/LexEnv.pm	2008-06-02 20:02:05 UTC (rev 4457)
@@ -2,11 +2,6 @@
 use Devel::REPL::Plugin;
 use namespace::clean -except => [ 'meta' ];
 
-with qw(
-  Devel::REPL::Plugin::Completion
-  Devel::REPL::Plugin::LexEnv
-);
-
 around complete => sub {
   my $orig = shift;
   my ($self, $text, $document) = @_;

Modified: trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/Methods.pm
===================================================================
--- trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/Methods.pm	2008-06-02 18:46:12 UTC (rev 4456)
+++ trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/Methods.pm	2008-06-02 20:02:05 UTC (rev 4457)
@@ -2,10 +2,12 @@
 use Devel::REPL::Plugin;
 use namespace::clean -except => [ 'meta' ];
 
-with qw(
-  Devel::REPL::Plugin::Completion
-  Devel::REPL::Plugin::FindVariable
-);
+sub BEFORE_PLUGIN {
+    my $self = shift;
+    for (qw/Completion FindVariable/) {
+        $self->load_plugin($_);
+    }
+}
 
 around complete => sub {
   my $orig = shift;

Modified: trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/Turtles.pm
===================================================================
--- trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/Turtles.pm	2008-06-02 18:46:12 UTC (rev 4456)
+++ trunk/Devel-REPL/lib/Devel/REPL/Plugin/CompletionDriver/Turtles.pm	2008-06-02 20:02:05 UTC (rev 4457)
@@ -5,11 +5,6 @@
 
 use namespace::clean -except => [ "meta" ];
 
-with qw(
-  Devel::REPL::Plugin::Completion
-  Devel::REPL::Plugin::Turtles
-);
-
 around complete => sub {
   my $orig = shift;
   my ($self, $text, $document) = @_;

Modified: trunk/Devel-REPL/lib/Devel/REPL/Plugin/LexEnv.pm
===================================================================
--- trunk/Devel-REPL/lib/Devel/REPL/Plugin/LexEnv.pm	2008-06-02 18:46:12 UTC (rev 4456)
+++ trunk/Devel-REPL/lib/Devel/REPL/Plugin/LexEnv.pm	2008-06-02 20:02:05 UTC (rev 4457)
@@ -4,7 +4,10 @@
 use namespace::clean -except => [ 'meta' ];
 use Lexical::Persistence;
 
-with 'Devel::REPL::Plugin::FindVariable';
+sub BEFORE_PLUGIN {
+    my $self = shift;
+    $self->load_plugin('FindVariable');
+}
 
 has 'lexical_environment' => (
   isa => 'Lexical::Persistence',

Modified: trunk/Devel-REPL/lib/Devel/REPL/Plugin/Nopaste.pm
===================================================================
--- trunk/Devel-REPL/lib/Devel/REPL/Plugin/Nopaste.pm	2008-06-02 18:46:12 UTC (rev 4456)
+++ trunk/Devel-REPL/lib/Devel/REPL/Plugin/Nopaste.pm	2008-06-02 20:02:05 UTC (rev 4457)
@@ -4,7 +4,10 @@
 use MooseX::AttributeHelpers;
 use namespace::clean -except => [ 'meta' ];
 
-with 'Devel::REPL::Plugin::Turtles';
+sub BEFORE_PLUGIN {
+    my $self = shift;
+    $self->load_plugin('Turtles');
+}
 
 has complete_session => (
     metaclass => 'String',

Modified: trunk/Devel-REPL/lib/Devel/REPL/Plugin/PPI.pm
===================================================================
--- trunk/Devel-REPL/lib/Devel/REPL/Plugin/PPI.pm	2008-06-02 18:46:12 UTC (rev 4456)
+++ trunk/Devel-REPL/lib/Devel/REPL/Plugin/PPI.pm	2008-06-02 20:02:05 UTC (rev 4457)
@@ -8,7 +8,10 @@
 
 use namespace::clean -except => [ 'meta' ];
 
-with qw(Devel::REPL::Plugin::Turtles);
+sub BEFORE_PLUGIN {
+    my $self = shift;
+    $self->load_plugin('Turtles');
+}
 
 sub expr_command_ppi {
   my ( $self, $eval, $code ) = @_;

Modified: trunk/Devel-REPL/lib/Devel/REPL/Plugin/Peek.pm
===================================================================
--- trunk/Devel-REPL/lib/Devel/REPL/Plugin/Peek.pm	2008-06-02 18:46:12 UTC (rev 4456)
+++ trunk/Devel-REPL/lib/Devel/REPL/Plugin/Peek.pm	2008-06-02 20:02:05 UTC (rev 4457)
@@ -7,7 +7,10 @@
 
 use namespace::clean -except => [ 'meta' ];
 
-with qw(Devel::REPL::Plugin::Turtles);
+sub BEFORE_PLUGIN {
+    my $self = shift;
+    $self->load_plugin('Turtles');
+}
 
 sub expr_command_peek {
   my ( $self, $eval, $code ) = @_;




More information about the Bast-commits mailing list