[Bast-commits] r4219 - in DBIx-Class/0.08/branches/savepoints/lib/DBIx/Class/Storage: . DBI

gphat at dev.catalyst.perl.org gphat at dev.catalyst.perl.org
Sun Mar 23 23:52:13 GMT 2008


Author: gphat
Date: 2008-03-23 23:52:13 +0000 (Sun, 23 Mar 2008)
New Revision: 4219

Modified:
   DBIx-Class/0.08/branches/savepoints/lib/DBIx/Class/Storage/DBI.pm
   DBIx-Class/0.08/branches/savepoints/lib/DBIx/Class/Storage/DBI/Oracle.pm
   DBIx-Class/0.08/branches/savepoints/lib/DBIx/Class/Storage/DBI/Pg.pm
   DBIx-Class/0.08/branches/savepoints/lib/DBIx/Class/Storage/DBI/mysql.pm
Log:
Remove unnecessary passing of $self->dbh as a separate param to savepoint methods

Modified: DBIx-Class/0.08/branches/savepoints/lib/DBIx/Class/Storage/DBI/Oracle.pm
===================================================================
--- DBIx-Class/0.08/branches/savepoints/lib/DBIx/Class/Storage/DBI/Oracle.pm	2008-03-23 23:42:04 UTC (rev 4218)
+++ DBIx-Class/0.08/branches/savepoints/lib/DBIx/Class/Storage/DBI/Oracle.pm	2008-03-23 23:52:13 UTC (rev 4219)
@@ -26,17 +26,17 @@
 }
 
 sub _svp_begin {
-    my ($self, $dbh, $name) = @_;
+    my ($self, $name) = @_;
  
-    $dbh->do("SAVEPOINT $name");
+    $self->dbh->do("SAVEPOINT $name");
 }
 
 # Would've implemented _svp_release here, but Oracle doesn't support it.
 
 sub _svp_rollback {
-    my ($self, $dbh, $name) = @_;
+    my ($self, $name) = @_;
 
-    $dbh->do("ROLLBACK TO SAVEPOINT $name")
+    $self->dbh->do("ROLLBACK TO SAVEPOINT $name")
 }
 
 1;

Modified: DBIx-Class/0.08/branches/savepoints/lib/DBIx/Class/Storage/DBI/Pg.pm
===================================================================
--- DBIx-Class/0.08/branches/savepoints/lib/DBIx/Class/Storage/DBI/Pg.pm	2008-03-23 23:42:04 UTC (rev 4218)
+++ DBIx-Class/0.08/branches/savepoints/lib/DBIx/Class/Storage/DBI/Pg.pm	2008-03-23 23:52:13 UTC (rev 4219)
@@ -80,21 +80,21 @@
 }
 
 sub _svp_begin {
-    my ($self, $dbh, $name) = @_;
+    my ($self, $name) = @_;
 
-    $dbh->pg_savepoint($name);
+    $self->dbh->pg_savepoint($name);
 }
 
 sub _svp_release {
-    my ($self, $dbh, $name) = @_;
+    my ($self, $name) = @_;
 
-    $dbh->pg_release($name;)
+    $self->dbh->pg_release($name;)
 }
 
 sub _svp_rollback {
-    my ($self, $dbh, $name) = @_;
+    my ($self, $name) = @_;
 
-    $dbh->pg_rollback_to($name);
+    $self->dbh->pg_rollback_to($name);
 }
 
 1;

Modified: DBIx-Class/0.08/branches/savepoints/lib/DBIx/Class/Storage/DBI/mysql.pm
===================================================================
--- DBIx-Class/0.08/branches/savepoints/lib/DBIx/Class/Storage/DBI/mysql.pm	2008-03-23 23:42:04 UTC (rev 4218)
+++ DBIx-Class/0.08/branches/savepoints/lib/DBIx/Class/Storage/DBI/mysql.pm	2008-03-23 23:52:13 UTC (rev 4219)
@@ -17,21 +17,21 @@
 }
 
 sub _svp_begin {
-    my ($self, $dbh, $name) = @_;
+    my ($self, $name) = @_;
 
-    $dbh->do("SAVEPOINT $name");
+    $self->dbh->do("SAVEPOINT $name");
 }
 
 sub _svp_release {
-    my ($self, $dbh, $name) = @_;
+    my ($self, $name) = @_;
 
-    $dbh->do("RELEASE SAVEPOINT $name");
+    $self->dbh->do("RELEASE SAVEPOINT $name");
 }
 
 sub _svp_rollback {
-    my ($self, $dbh, $name) = @_;
+    my ($self, $name) = @_;
 
-    $dbh->do("ROLLBACK TO SAVEPOINT $name")
+    $self->dbh->do("ROLLBACK TO SAVEPOINT $name")
 }
 
 1;

Modified: DBIx-Class/0.08/branches/savepoints/lib/DBIx/Class/Storage/DBI.pm
===================================================================
--- DBIx-Class/0.08/branches/savepoints/lib/DBIx/Class/Storage/DBI.pm	2008-03-23 23:42:04 UTC (rev 4218)
+++ DBIx-Class/0.08/branches/savepoints/lib/DBIx/Class/Storage/DBI.pm	2008-03-23 23:52:13 UTC (rev 4219)
@@ -882,7 +882,7 @@
     return 0;
   }
   $self->debugobj->svp_begin($name) if $self->debug;
-  $self->_svp_begin($self->dbh(), $name);
+  $self->_svp_begin($name);
 }
 
 sub svp_release {
@@ -900,7 +900,7 @@
       return 0;
   }
   $self->debugobj->svp_release($name) if $self->debug;
-  $self->_svp_release($self->dbh(), $name);
+  $self->_svp_release($name);
 }
 
 sub svp_rollback {
@@ -918,7 +918,7 @@
       return 0;
   }
   $self->debugobj->svp_rollback($name) if $self->debug;
-  $self->_svp_rollback($self->dbh(), $name);
+  $self->_svp_rollback($name);
 }
 
 sub txn_begin {




More information about the Bast-commits mailing list