[Bast-commits] r5010 - in DBIx-Class/0.08/branches/doc_mods: lib/DBIx/Class/Manual t

[nigel at dev.catalyst.perl.org]

Author: nigel
Date: 2008-10-27 21:55:55 +0000 (Mon, 27 Oct 2008)
New Revision: 5010

Modified:
   DBIx-Class/0.08/branches/doc_mods/lib/DBIx/Class/Manual/Troubleshooting.pod
   DBIx-Class/0.08/branches/doc_mods/t/99rh_perl_perf_bug.t
Log:
Minor tweaks to RH perf issue stuff following suggestions from ribasushi>

Modified: DBIx-Class/0.08/branches/doc_mods/lib/DBIx/Class/Manual/Troubleshooting.pod
===================================================================
--- DBIx-Class/0.08/branches/doc_mods/lib/DBIx/Class/Manual/Troubleshooting.pod	2008-10-27 21:42:51 UTC (rev 5009)
+++ DBIx-Class/0.08/branches/doc_mods/lib/DBIx/Class/Manual/Troubleshooting.pod	2008-10-27 21:55:55 UTC (rev 5010)
@@ -128,7 +128,7 @@
 There is a problem with slow performance of certain DBIx::Class
 operations using the system perl on some Fedora and Red Hat Enterprise
 Linux system (as well as their derivative distributions such as Centos,
-White Box and Scientific Linix).
+White Box and Scientific Linux).
 
 Distributions affected include Fedora 5 through to Fedora 8 and RHEL5
 upto and including RHEL5 Update 2. Fedora 9 (which uses perl 5.10) has

Modified: DBIx-Class/0.08/branches/doc_mods/t/99rh_perl_perf_bug.t
===================================================================
--- DBIx-Class/0.08/branches/doc_mods/t/99rh_perl_perf_bug.t	2008-10-27 21:42:51 UTC (rev 5009)
+++ DBIx-Class/0.08/branches/doc_mods/t/99rh_perl_perf_bug.t	2008-10-27 21:55:55 UTC (rev 5010)
@@ -16,7 +16,7 @@
 # variable
 #
 # If these tests fail then please read the section titled
-# Perl Performance Issues on Red Hat Systems in 
+# Perl Performance Issues on Red Hat Systems in
 # L<DBIx::Class::Manual::Troubleshooting>
 
 plan skip_all =>
@@ -50,7 +50,7 @@
     'Checking not susceptable to bless/overload performance problem' );
 
 my $results = timethese(
-    0,
+    -1,    # run for 1 CPU second each
     {
         overload => sub {
             use overload q(<) => sub { };
@@ -68,5 +68,9 @@
     }
 );
 
+# we are OK if there is less than a factor of 2 difference here
 ok( ( ( $results->{nooverload}->iters / $results->{overload}->iters ) < 2 ),
     'Overload/bless performance acceptable' )
+# if the test above failed, look at the section titled
+# Perl Performance Issues on Red Hat Systems in
+# L<DBIx::Class::Manual::Troubleshooting>
\ No newline at end of file