[Bast-commits] r4796 - in DBIx-Class/0.08/trunk/t: . cdbi-DeepAbstractSearch cdbi-t

[ribasushi at dev.catalyst.perl.org]

Author: ribasushi
Date: 2008-09-09 23:59:42 +0100 (Tue, 09 Sep 2008)
New Revision: 4796

Modified:
   DBIx-Class/0.08/trunk/t/73oracle_inflate.t
   DBIx-Class/0.08/trunk/t/cdbi-DeepAbstractSearch/01_search.t
   DBIx-Class/0.08/trunk/t/cdbi-t/15-accessor.t
   DBIx-Class/0.08/trunk/t/cdbi-t/22-deflate_order.t
Log:
Consistent skip messages throughout the test suite (consists of a simple reordering of prerequisite eval checks)

Modified: DBIx-Class/0.08/trunk/t/73oracle_inflate.t
===================================================================
--- DBIx-Class/0.08/trunk/t/73oracle_inflate.t	2008-09-09 22:56:22 UTC (rev 4795)
+++ DBIx-Class/0.08/trunk/t/73oracle_inflate.t	2008-09-09 22:59:42 UTC (rev 4796)
@@ -7,16 +7,18 @@
 
 my ($dsn, $user, $pass) = @ENV{map { "DBICTEST_ORA_${_}" } qw/DSN USER PASS/};
 
-eval "use DateTime; use DateTime::Format::Oracle;";
-if ($@) {
-    plan skip_all => 'needs DateTime and DateTime::Format::Oracle for testing';
-}
-elsif (not ($dsn && $user && $pass)) {
+if (not ($dsn && $user && $pass)) {
     plan skip_all => 'Set $ENV{DBICTEST_ORA_DSN}, _USER and _PASS to run this test. ' .
          'Warning: This test drops and creates a table called \'track\'';
 }
 else {
-    plan tests => 4;
+    eval "use DateTime; use DateTime::Format::Oracle;";
+    if ($@) {
+        plan skip_all => 'needs DateTime and DateTime::Format::Oracle for testing';
+    }
+    else {
+        plan tests => 4;
+    }
 }
 
 # DateTime::Format::Oracle needs this set

Modified: DBIx-Class/0.08/trunk/t/cdbi-DeepAbstractSearch/01_search.t
===================================================================
--- DBIx-Class/0.08/trunk/t/cdbi-DeepAbstractSearch/01_search.t	2008-09-09 22:56:22 UTC (rev 4795)
+++ DBIx-Class/0.08/trunk/t/cdbi-DeepAbstractSearch/01_search.t	2008-09-09 22:59:42 UTC (rev 4796)
@@ -2,6 +2,12 @@
 use Test::More;
 
 BEGIN {
+    eval "use DBIx::Class::CDBICompat;";
+    if ($@) {
+        plan (skip_all => "Class::Trigger and DBIx::ContextualFetch required: $@");
+        next;
+    }
+
     plan skip_all => 'needs DBD::SQLite for testing'
         unless eval { require DBD::SQLite };
     

Modified: DBIx-Class/0.08/trunk/t/cdbi-t/15-accessor.t
===================================================================
--- DBIx-Class/0.08/trunk/t/cdbi-t/15-accessor.t	2008-09-09 22:56:22 UTC (rev 4795)
+++ DBIx-Class/0.08/trunk/t/cdbi-t/15-accessor.t	2008-09-09 22:59:42 UTC (rev 4796)
@@ -4,7 +4,6 @@
 BEGIN {
   eval "use DBIx::Class::CDBICompat;";
   if ($@) {
-      diag $@;
     plan (skip_all => 'Class::Trigger and DBIx::ContextualFetch required');
     next;
   }

Modified: DBIx-Class/0.08/trunk/t/cdbi-t/22-deflate_order.t
===================================================================
--- DBIx-Class/0.08/trunk/t/cdbi-t/22-deflate_order.t	2008-09-09 22:56:22 UTC (rev 4795)
+++ DBIx-Class/0.08/trunk/t/cdbi-t/22-deflate_order.t	2008-09-09 22:59:42 UTC (rev 4796)
@@ -3,6 +3,12 @@
 
 use Test::More;
 
+eval "use DBIx::Class::CDBICompat;";
+if ($@) {
+    plan (skip_all => "Class::Trigger and DBIx::ContextualFetch required: $@");
+    next;
+}
+
 eval { require Time::Piece::MySQL };
 plan skip_all => "Need Time::Piece::MySQL for this test" if $@;