[Bast-commits] r4842 - DBIx-Class/0.08/branches/warnfree/t

ribasushi at dev.catalyst.perl.org ribasushi at dev.catalyst.perl.org
Mon Sep 22 02:00:53 BST 2008


Author: ribasushi
Date: 2008-09-22 02:00:53 +0100 (Mon, 22 Sep 2008)
New Revision: 4842

Modified:
   DBIx-Class/0.08/branches/warnfree/t/47bind_attribute.t
   DBIx-Class/0.08/branches/warnfree/t/93single_accessor_object.t
Log:
Blindly silence a weird warning within a TODO in t/47bind_attribute.t. Hopefully when the TODO is resolved, it will be obvious what was causing it
Merge the t/93single_accessor_object.t fix from trunk

Modified: DBIx-Class/0.08/branches/warnfree/t/47bind_attribute.t
===================================================================
--- DBIx-Class/0.08/branches/warnfree/t/47bind_attribute.t	2008-09-22 00:34:54 UTC (rev 4841)
+++ DBIx-Class/0.08/branches/warnfree/t/47bind_attribute.t	2008-09-22 01:00:53 UTC (rev 4842)
@@ -73,6 +73,10 @@
 is ( $rs->count, 1, '...cookbook (bind first) + chained search' );
 
 TODO: {
+    # not sure what causes an uninit warning here, please remove when the TODO starts to pass,
+    # so the real reason for the warning can be found and fixed
+    local $SIG{__WARN__} = sub { warn @_ unless $_[0] =~ /uninitialized/ };
+
     local $TODO = 'bind args order needs fixing (semifor)';
     $rs = $schema->resultset('Complex')->search({}, { bind => [ 1999 ] })
         ->search({ 'artistid' => 1 }, {

Modified: DBIx-Class/0.08/branches/warnfree/t/93single_accessor_object.t
===================================================================
--- DBIx-Class/0.08/branches/warnfree/t/93single_accessor_object.t	2008-09-22 00:34:54 UTC (rev 4841)
+++ DBIx-Class/0.08/branches/warnfree/t/93single_accessor_object.t	2008-09-22 01:00:53 UTC (rev 4842)
@@ -56,7 +56,7 @@
 
 {
 	my $artist = $schema->resultset('Artist')->create({ artistid => 666, name => 'bad religion' });
-	my $genre = $schema->resultset('Genre')->create({ name => 'disco' });
+	my $genre = $schema->resultset('Genre')->create({ genreid => 88, name => 'disco' });
 	my $cd = $schema->resultset('CD')->create({ cdid => 187, artist => 1, title => 'how could hell be any worse?', year => 1982 });
 
 	dies_ok { $cd->genre } 'genre accessor throws without column';




More information about the Bast-commits mailing list