[Bast-commits] r5915 - in DBIx-Class/0.08/trunk: . lib/DBIx lib/DBIx/Class t

[arcanez at dev.catalyst.perl.org]

Author: arcanez
Date: 2009-04-20 23:07:07 +0100 (Mon, 20 Apr 2009)
New Revision: 5915

Modified:
   DBIx-Class/0.08/trunk/Makefile.PL
   DBIx-Class/0.08/trunk/lib/DBIx/Class.pm
   DBIx-Class/0.08/trunk/lib/DBIx/Class/Componentised.pm
   DBIx-Class/0.08/trunk/t/90ensure_class_loaded.t
Log:
move load_optional_class into Class::C3::Componentised


Modified: DBIx-Class/0.08/trunk/Makefile.PL
===================================================================
--- DBIx-Class/0.08/trunk/Makefile.PL	2009-04-20 22:00:43 UTC (rev 5914)
+++ DBIx-Class/0.08/trunk/Makefile.PL	2009-04-20 22:07:07 UTC (rev 5915)
@@ -13,7 +13,7 @@
 requires 'Scalar::Util'             => 0;
 requires 'SQL::Abstract'            => 1.51;
 requires 'SQL::Abstract::Limit'     => 0.13;
-requires 'Class::C3::Componentised' => 1.0004;
+requires 'Class::C3::Componentised' => 1.0005;
 requires 'Storable'                 => 0;
 requires 'Carp::Clan'               => 0;
 requires 'DBI'                      => 1.40;

Modified: DBIx-Class/0.08/trunk/lib/DBIx/Class/Componentised.pm
===================================================================
--- DBIx-Class/0.08/trunk/lib/DBIx/Class/Componentised.pm	2009-04-20 22:00:43 UTC (rev 5914)
+++ DBIx-Class/0.08/trunk/lib/DBIx/Class/Componentised.pm	2009-04-20 22:07:07 UTC (rev 5915)
@@ -31,25 +31,4 @@
   $class->next::method($target, @to_inject);
 }
 
-# Returns a true value if the specified class is installed and loaded
-# successfully, throws an exception if the class is found but not loaded
-# successfully, and false if the class is not installed
-sub load_optional_class {
-  my ($class, $f_class) = @_;
-  eval { $class->ensure_class_loaded($f_class) };
-  my $err = $@;   # so we don't lose it
-  if (! $err) {
-    return 1;
-  }
-  else {
-    my $fn = (join ('/', split ('::', $f_class) ) ) . '.pm';
-    if ($err =~ /Can't locate ${fn} in \@INC/ ) {
-      return 0;
-    }
-    else {
-      die $err;
-    }
-  }
-}
-
 1;

Modified: DBIx-Class/0.08/trunk/lib/DBIx/Class.pm
===================================================================
--- DBIx-Class/0.08/trunk/lib/DBIx/Class.pm	2009-04-20 22:00:43 UTC (rev 5914)
+++ DBIx-Class/0.08/trunk/lib/DBIx/Class.pm	2009-04-20 22:07:07 UTC (rev 5915)
@@ -207,6 +207,8 @@
 
 ank: Andres Kievsky
 
+arcanez: Justin Hunter <justin.d.hunter at gmail.com>
+
 ash: Ash Berlin <ash at cpan.org>
 
 bert: Norbert Csongradi <bert at cpan.org>

Modified: DBIx-Class/0.08/trunk/t/90ensure_class_loaded.t
===================================================================
--- DBIx-Class/0.08/trunk/t/90ensure_class_loaded.t	2009-04-20 22:00:43 UTC (rev 5914)
+++ DBIx-Class/0.08/trunk/t/90ensure_class_loaded.t	2009-04-20 22:07:07 UTC (rev 5915)
@@ -64,9 +64,12 @@
     q/0;/,
   );
 
-  $retval = eval { $schema->load_optional_class('VIRTUAL::PAR::PACKAGE') };
-  ok( $@, 'load_optional_class of a no-true-returning PAR module did throw' );
-  ok( !$retval, 'no-true-returning PAR package not loaded' );
+  TODO: {
+    local $TODO = "Current load_optional_class cannot find PAR";
+    $retval = eval { $schema->load_optional_class('VIRTUAL::PAR::PACKAGE') };
+    ok( $@, 'load_optional_class of a no-true-returning PAR module did throw' );
+    ok( !$retval, 'no-true-returning PAR package not loaded' );
+  }
 
   # simulate a normal class (no one adjusted %INC so it will be tried again
   @code = (
@@ -74,9 +77,12 @@
     q/1;/,
   );
 
-  $retval = eval { $schema->load_optional_class('VIRTUAL::PAR::PACKAGE') };
-  ok( !$@, 'load_optional_class of a PAR module did not throw' );
-  ok( $retval, 'PAR package "loaded"' );
+  TODO: {
+    local $TODO = "Current load_optional_class cannot find PARs";
+    $retval = eval { $schema->load_optional_class('VIRTUAL::PAR::PACKAGE') };
+    ok( !$@, 'load_optional_class of a PAR module did not throw' );
+    ok( $retval, 'PAR package "loaded"' );
+  }
 
   # see if we can still load stuff with the coderef present
   $retval = eval { $schema->load_optional_class('DBIx::Class::ResultClass::HashRefInflator') };