[Bast-commits] r6019 - DBIx-Class/0.08/trunk/t

[ribasushi at dev.catalyst.perl.org]

Author: ribasushi
Date: 2009-04-29 14:39:27 +0100 (Wed, 29 Apr 2009)
New Revision: 6019

Modified:
   DBIx-Class/0.08/trunk/t/76select.t
Log:
Strip out inane todo

Modified: DBIx-Class/0.08/trunk/t/76select.t
===================================================================
--- DBIx-Class/0.08/trunk/t/76select.t	2009-04-29 12:47:03 UTC (rev 6018)
+++ DBIx-Class/0.08/trunk/t/76select.t	2009-04-29 13:39:27 UTC (rev 6019)
@@ -9,7 +9,7 @@
 
 my $schema = DBICTest->init_schema();
 
-plan tests => 23;
+plan tests => 21;
 
 my $rs = $schema->resultset('CD')->search({},
     {
@@ -84,11 +84,10 @@
     }
 );
 
-my @query = @${$rs->as_query};
-TODO: { local $TODO = 'as_query() inconsistent'; is (scalar @query, 2, 'as_query() returned empty bindval arrayref') || push @query, [] }
-
+my ($sql, @bind) = @${$rs->as_query};
 is_same_sql_bind (
-  @query,
+  $sql,
+  \@bind,
   '(SELECT me.cdid, me.title, artist.name FROM cd me  JOIN artist artist ON artist.artistid = me.artist)',
   [],
   'Use of columns attribute results in proper sql'
@@ -115,11 +114,10 @@
     }
 );
 
- at query = @${$rs->as_query};
-TODO: { local $TODO = 'as_query() inconsistent'; is (scalar @query, 2, 'as_query() returned empty bindval arrayref') || push @query, [] }
-
+($sql, @bind) = @${$rs->as_query};
 is_same_sql_bind (
-  @query,
+  $sql,
+  \@bind,
   '(SELECT me.cdid, me.artist, me.title, me.year, me.genreid, me.single_track, me.cdid, me.title, artist.name FROM cd me  JOIN artist artist ON artist.artistid = me.artist)',
   [],
   'Use of columns attribute results in proper sql'