[Bast-commits] r7376 - in DBIx-Class/0.08/branches/sybase/lib/DBIx/Class/Storage/DBI: Oracle Sybase

caelum at dev.catalyst.perl.org caelum at dev.catalyst.perl.org
Mon Aug 24 15:19:46 GMT 2009


Author: caelum
Date: 2009-08-24 15:19:46 +0000 (Mon, 24 Aug 2009)
New Revision: 7376

Modified:
   DBIx-Class/0.08/branches/sybase/lib/DBIx/Class/Storage/DBI/Oracle/Generic.pm
   DBIx-Class/0.08/branches/sybase/lib/DBIx/Class/Storage/DBI/Sybase/Microsoft_SQL_Server.pm
Log:
remove duplicate oracle method and fix an mssql method call

Modified: DBIx-Class/0.08/branches/sybase/lib/DBIx/Class/Storage/DBI/Oracle/Generic.pm
===================================================================
--- DBIx-Class/0.08/branches/sybase/lib/DBIx/Class/Storage/DBI/Oracle/Generic.pm	2009-08-24 13:51:48 UTC (rev 7375)
+++ DBIx-Class/0.08/branches/sybase/lib/DBIx/Class/Storage/DBI/Oracle/Generic.pm	2009-08-24 15:19:46 UTC (rev 7376)
@@ -206,12 +206,6 @@
 "alter session set nls_timestamp_tz_format='$timestamp_tz_format'");
 }
 
-sub _svp_begin {
-    my ($self, $name) = @_;
-
-    $self->_get_dbh->do("SAVEPOINT $name");
-}
-
 =head2 source_bind_attributes
 
 Handle LOB types in Oracle.  Under a certain size (4k?), you can get away
@@ -259,7 +253,7 @@
 sub _svp_begin {
     my ($self, $name) = @_;
 
-    $self->last_dbh->do("SAVEPOINT $name");
+    $self->_get_dbh->do("SAVEPOINT $name");
 }
 
 # Oracle automatically releases a savepoint when you start another one with the

Modified: DBIx-Class/0.08/branches/sybase/lib/DBIx/Class/Storage/DBI/Sybase/Microsoft_SQL_Server.pm
===================================================================
--- DBIx-Class/0.08/branches/sybase/lib/DBIx/Class/Storage/DBI/Sybase/Microsoft_SQL_Server.pm	2009-08-24 13:51:48 UTC (rev 7375)
+++ DBIx-Class/0.08/branches/sybase/lib/DBIx/Class/Storage/DBI/Sybase/Microsoft_SQL_Server.pm	2009-08-24 15:19:46 UTC (rev 7376)
@@ -13,7 +13,7 @@
   my $self = shift;
   my $dbh  = $self->_get_dbh;
 
-  if (not $self->placeholders_with_type_conversion_supported) {
+  if (not $self->_typeless_placeholders_supported) {
     bless $self,
       'DBIx::Class::Storage::DBI::Sybase::Microsoft_SQL_Server::NoBindVars';
     $self->_rebless;




More information about the Bast-commits mailing list