[Bast-commits] r8132 - in DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI: . ADO

[caelum at dev.catalyst.perl.org]

Author: caelum
Date: 2009-12-17 12:34:20 +0000 (Thu, 17 Dec 2009)
New Revision: 8132

Modified:
   DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/ADO.pm
   DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/ADO/Microsoft_SQL_Server.pm
Log:
minor changes

Modified: DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/ADO/Microsoft_SQL_Server.pm
===================================================================
--- DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/ADO/Microsoft_SQL_Server.pm	2009-12-17 12:30:10 UTC (rev 8131)
+++ DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/ADO/Microsoft_SQL_Server.pm	2009-12-17 12:34:20 UTC (rev 8132)
@@ -42,6 +42,7 @@
 }
 
 # approximate
+# XXX needs to support varchar(max) and varbinary(max)
 sub _mssql_max_data_type_representation_size_in_bytes {
   my $self = shift;
 
@@ -65,6 +66,7 @@
     money => 100,
     float => 100,
     real => 100,
+    uniqueidentifier => 100,
     ntext => $blob_max,
     text => $blob_max,
     image => $blob_max,

Modified: DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/ADO.pm
===================================================================
--- DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/ADO.pm	2009-12-17 12:30:10 UTC (rev 8131)
+++ DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/ADO.pm	2009-12-17 12:34:20 UTC (rev 8132)
@@ -26,7 +26,8 @@
   }
 }
 
-# set cursor type here, if necessary
+# Here I was just experimenting with ADO cursor types, left in as a comment in
+# case you want to as well. See the DBD::ADO docs.
 #sub _dbh_sth {
 #  my ($self, $dbh, $sql) = @_;
 #