[Bast-commits] r5410 - in DBIx-Class/0.08/branches/multi_stuff: . lib/DBIx/Class

groditi at dev.catalyst.perl.org groditi at dev.catalyst.perl.org
Wed Feb 4 22:19:45 GMT 2009


Author: groditi
Date: 2009-02-04 22:19:45 +0000 (Wed, 04 Feb 2009)
New Revision: 5410

Modified:
   DBIx-Class/0.08/branches/multi_stuff/Changes
   DBIx-Class/0.08/branches/multi_stuff/lib/DBIx/Class/Row.pm
Log:
use store_column instead of set_column on insert

Modified: DBIx-Class/0.08/branches/multi_stuff/Changes
===================================================================
--- DBIx-Class/0.08/branches/multi_stuff/Changes	2009-02-04 21:23:06 UTC (rev 5409)
+++ DBIx-Class/0.08/branches/multi_stuff/Changes	2009-02-04 22:19:45 UTC (rev 5410)
@@ -14,6 +14,8 @@
         - new order_by => { -desc => 'colname' } syntax supported with
           SQLA >= 1.50
         - PG array datatype supported with SQLA >= 1.50
+        - insert should use store_column, not set_column to avoid marking
+          clean just-stored values as dirty. New test for this (groditi)
 
 0.08099_05 2008-10-30 21:30:00 (UTC)
         - Rewritte of Storage::DBI::connect_info(), extended with an

Modified: DBIx-Class/0.08/branches/multi_stuff/lib/DBIx/Class/Row.pm
===================================================================
--- DBIx-Class/0.08/branches/multi_stuff/lib/DBIx/Class/Row.pm	2009-02-04 21:23:06 UTC (rev 5409)
+++ DBIx-Class/0.08/branches/multi_stuff/lib/DBIx/Class/Row.pm	2009-02-04 22:19:45 UTC (rev 5410)
@@ -263,7 +263,9 @@
   }
 
   my $updated_cols = $source->storage->insert($source, { $self->get_columns });
-  $self->set_columns($updated_cols);
+  foreach my $col (keys %$updated_cols) {
+    $self->store_column($col, $updated_cols->{$col});
+  }
 
   ## PK::Auto
   my @auto_pri = grep {




More information about the Bast-commits mailing list