[Bast-commits] r5662 - in DBIx-Class/0.08/trunk: . lib/DBIx/Class/Storage/DBI t

[ribasushi at dev.catalyst.perl.org]

Author: ribasushi
Date: 2009-02-27 01:24:37 +0000 (Fri, 27 Feb 2009)
New Revision: 5662

Modified:
   DBIx-Class/0.08/trunk/Changes
   DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/NoBindVars.pm
   DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/Sybase.pm
   DBIx-Class/0.08/trunk/t/03podcoverage.t
Log:
Fix some should_quote_data_type problems

Modified: DBIx-Class/0.08/trunk/Changes
===================================================================
--- DBIx-Class/0.08/trunk/Changes	2009-02-27 01:06:55 UTC (rev 5661)
+++ DBIx-Class/0.08/trunk/Changes	2009-02-27 01:24:37 UTC (rev 5662)
@@ -16,7 +16,9 @@
           to make it more matpath-friendly
         - deploy_statements called ddl_filename with the $version and $dir arguments
           in the wrong order. (groditi)
+        - columns/+columns attributes now support { as => select } hahsrefs
 
+
 0.08099_06 2009-01-23 07:30:00 (UTC)
         - Allow a scalarref to be supplied to the 'from' resultset attribute
         - Classes submitted as result_class for a resultsource are now

Modified: DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/NoBindVars.pm
===================================================================
--- DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/NoBindVars.pm	2009-02-27 01:06:55 UTC (rev 5661)
+++ DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/NoBindVars.pm	2009-02-27 01:24:37 UTC (rev 5662)
@@ -64,6 +64,19 @@
   return ($new_sql);
 }
 
+=head2 should_quote_data_type
+
+This method is called by L</_prep_for_execute> for every column in
+order to determine if its value should be quoted or not. The sole
+argument is the current column data type, and the return value is
+interpreted as: true - do quote, false - do not quote. You should
+override this in you Storage::DBI::<database> subclass, if your
+RDBMS does not like quotes around certain datatypes (e.g. Sybase
+and integer columns). The default method always returns true (do
+quote).
+
+=cut
+
 sub should_quote_data_type { 1 }
 
 =head1 AUTHORS

Modified: DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/Sybase.pm
===================================================================
--- DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/Sybase.pm	2009-02-27 01:06:55 UTC (rev 5661)
+++ DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/Sybase.pm	2009-02-27 01:24:37 UTC (rev 5662)
@@ -5,7 +5,7 @@
 
 use base qw/DBIx::Class::Storage::DBI::NoBindVars/;
 
-my %noquote = map ($_ => 1), qw(int integer);
+my %noquote = map { $_ => 1 } qw(int integer);
 
 sub should_quote_data_type {
   my $self = shift;

Modified: DBIx-Class/0.08/trunk/t/03podcoverage.t
===================================================================
--- DBIx-Class/0.08/trunk/t/03podcoverage.t	2009-02-27 01:06:55 UTC (rev 5661)
+++ DBIx-Class/0.08/trunk/t/03podcoverage.t	2009-02-27 01:24:37 UTC (rev 5662)
@@ -44,6 +44,11 @@
             qw(setup_connection_class)
         ]
     },
+    'DBIx::Class::Storage::DBI::Sybase' => {
+        ignore => [
+            qw/should_quote_data_type/,
+        ]
+    },
     'DBIx::Class::CDBICompat::AccessorMapping'          => { skip => 1 },
     'DBIx::Class::CDBICompat::AbstractSearch' => {
         ignore => [qw(search_where)]