[Bast-commits] r5354 - DBIx-Class/0.08/trunk

[ribasushi at dev.catalyst.perl.org]

Author: ribasushi
Date: 2009-01-28 07:45:46 +0000 (Wed, 28 Jan 2009)
New Revision: 5354

Modified:
   DBIx-Class/0.08/trunk/Makefile.PL
Log:
Special treatment of windows users - you can not segfault in a fork as there is no proper fork()

Modified: DBIx-Class/0.08/trunk/Makefile.PL
===================================================================
--- DBIx-Class/0.08/trunk/Makefile.PL	2009-01-27 11:58:05 UTC (rev 5353)
+++ DBIx-Class/0.08/trunk/Makefile.PL	2009-01-28 07:45:46 UTC (rev 5354)
@@ -64,14 +64,42 @@
 auto_install;
 
 # Have all prerequisites, check DBD::SQLite sanity
-{
+if (! $ENV{DBICTEST_NO_SQLITE_CHECK} ) {
+
   my $pid = fork();
   if (not defined $pid) {
       die "Unable to fork(): $!";
   }
   elsif (! $pid) {
+
+      # Win32 does not have real fork()s so a segfault will bring
+      # everything down. Warn about it.
+      if ($^O eq 'MSWin32') {
+        print <<'EOW';
+
+######################################################################
+#                                                                    #
+# A short stress-testing of DBD::SQLite will follow. If you have a   #
+# buggy library this might very well be the last text you will see   #
+# before the installation silently terminates. If this happens it    #
+# would mean that you are running a buggy version of DBD::SQLite     #
+# known to randomly segfault on errors. Even if you have the latest  #
+# CPAN module version, the actual sqlite3 dynamic library might have #
+# been compiled against an older buggy sqlite3 dev library. You are  #
+# strongly advised to update DBD::SQLite.                            #
+#                                                                    #
+# If this happens to you (this text is the last thing you see), and  #
+# you just want to install this module without worrying about the    #
+# tests (which will almost certainly fail) - set the environment     #
+# variable DBICTEST_NO_SQLITE_CHECK to a true value and try again.   #
+#                                                                    #
+######################################################################
+
+EOW
+      }
+
       require DBI;
-      for (1 .. 10) {
+      for (1 .. 100) {
           my $dbh;
           $dbh = DBI->connect ('dbi:SQLite::memory:', undef, undef, {
               AutoCommit => 1,
@@ -145,6 +173,3 @@
   ];
   Meta->write;
 }
-
-
-