[Bast-commits] r5383 - in DBIx-Class/0.08/trunk:
lib/DBIx/Class/Storage t
castaway at dev.catalyst.perl.org
castaway at dev.catalyst.perl.org
Fri Jan 30 14:27:38 GMT 2009
Author: castaway
Date: 2009-01-30 14:27:38 +0000 (Fri, 30 Jan 2009)
New Revision: 5383
Modified:
DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI.pm
DBIx-Class/0.08/trunk/t/745db2.t
Log:
DB2 compatibility fix, update test to add new artist column (ick)
remove code that calls now removed sub _RowNumberOver
Modified: DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI.pm
===================================================================
--- DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI.pm 2009-01-30 13:54:42 UTC (rev 5382)
+++ DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI.pm 2009-01-30 14:27:38 UTC (rev 5383)
@@ -50,19 +50,11 @@
$self;
}
+
# While we're at it, this should make LIMIT queries more efficient,
# without digging into things too deeply
use Scalar::Util 'blessed';
-sub _find_syntax {
- my ($self, $syntax) = @_;
- my $dbhname = blessed($syntax) ? $syntax->{Driver}{Name} : $syntax;
- if(ref($self) && $dbhname && $dbhname eq 'DB2') {
- return 'RowNumberOver';
- }
- $self->{_cached_syntax} ||= $self->SUPER::_find_syntax($syntax);
-}
-
sub select {
my ($self, $table, $fields, $where, $order, @rest) = @_;
if (ref $table eq 'SCALAR') {
Modified: DBIx-Class/0.08/trunk/t/745db2.t
===================================================================
--- DBIx-Class/0.08/trunk/t/745db2.t 2009-01-30 13:54:42 UTC (rev 5382)
+++ DBIx-Class/0.08/trunk/t/745db2.t 2009-01-30 14:27:38 UTC (rev 5383)
@@ -20,7 +20,7 @@
eval { $dbh->do("DROP TABLE artist") };
-$dbh->do("CREATE TABLE artist (artistid INTEGER GENERATED BY DEFAULT AS IDENTITY (START WITH 1, INCREMENT BY 1), name VARCHAR(255), charfield CHAR(10));");
+$dbh->do("CREATE TABLE artist (artistid INTEGER GENERATED BY DEFAULT AS IDENTITY (START WITH 1, INCREMENT BY 1), name VARCHAR(255), charfield CHAR(10), rank INTEGER DEFAULT 13);");
# This is in core, just testing that it still loads ok
$schema->class('Artist')->load_components('PK::Auto');
More information about the Bast-commits
mailing list