[Bast-commits] r6981 - in DBIx-Class/0.08/trunk: . lib/DBIx/Class/Storage/DBI t

[ribasushi at dev.catalyst.perl.org]

Author: ribasushi
Date: 2009-07-04 09:45:24 +0000 (Sat, 04 Jul 2009)
New Revision: 6981

Modified:
   DBIx-Class/0.08/trunk/Changes
   DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/mysql.pm
   DBIx-Class/0.08/trunk/t/71mysql.t
Log:
Backout mysql changes for further polishing

Modified: DBIx-Class/0.08/trunk/Changes
===================================================================
--- DBIx-Class/0.08/trunk/Changes	2009-07-04 09:37:25 UTC (rev 6980)
+++ DBIx-Class/0.08/trunk/Changes	2009-07-04 09:45:24 UTC (rev 6981)
@@ -10,8 +10,6 @@
           POD of Storage::DBI)
         - Automatic datetime handling environment/session setup for
           Oracle via connect_call_datetime_setup()
-        - MySQL can now be turned into a sane database by adding
-          { on_connect_call => 'set_ansi_mode' } to the connect() call
         - count/all on related left-joined empty resultsets now correctly
           returns 0/()
         - Fixed regression when both page and offset are specified on

Modified: DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/mysql.pm
===================================================================
--- DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/mysql.pm	2009-07-04 09:37:25 UTC (rev 6980)
+++ DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/mysql.pm	2009-07-04 09:45:24 UTC (rev 6981)
@@ -20,12 +20,6 @@
   $self->_do_query('SET FOREIGN_KEY_CHECKS = 1');
 }
 
-sub connect_call_set_ansi_mode {
-  my $self = shift;
-  $self->_do_query(q|SET SQL_MODE = 'ANSI,TRADITIONAL'|);
-  $self->_do_query(q|SET SQL_AUTO_IS_NULL = 0|);
-}
-
 sub _dbh_last_insert_id {
   my ($self, $dbh, $source, $col) = @_;
   $dbh->{mysql_insertid};
@@ -85,9 +79,6 @@
 
 This class implements MySQL specific bits of L<DBIx::Class::Storage::DBI>.
 
-It also provides a one-stop macro that sets session variables such that
-MySQL behaves more predictably as far as the SQL standard is concerned.
-
 =head1 AUTHORS
 
 See L<DBIx::Class/CONTRIBUTORS>

Modified: DBIx-Class/0.08/trunk/t/71mysql.t
===================================================================
--- DBIx-Class/0.08/trunk/t/71mysql.t	2009-07-04 09:37:25 UTC (rev 6980)
+++ DBIx-Class/0.08/trunk/t/71mysql.t	2009-07-04 09:45:24 UTC (rev 6981)
@@ -164,13 +164,13 @@
 ##
 ## Only way is to do a SET SQL_AUTO_IS_NULL = 0; on connect
 ## But I'm not sure if we should do this or not (Ash, 2008/06/03)
-#
-# There is now a built-in function to do this, test that everything works
-# with it (ribasushi, 2009/07/03)
 
 NULLINSEARCH: {
-    my $ansi_schema = DBICTest::Schema->connect ($dsn, $user, $pass, { on_connect_call => 'set_ansi_mode' });
+    local $TODO = 'Fix pending in branches/mysql_ansi';
+    my $ansi_schema = DBICTest::Schema->connect ($dsn, $user, $pass);
 
+    $ansi_schema->resultset('Artist')->create ({ name => 'last created artist' });
+
     ok my $artist1_rs = $ansi_schema->resultset('Artist')->search({artistid=>6666})
       => 'Created an artist resultset of 6666';