[Bast-commits] r6983 - in DBIx-Class/0.08/branches/mysql_ansi: lib/DBIx/Class/Storage/DBI t

ribasushi at dev.catalyst.perl.org ribasushi at dev.catalyst.perl.org
Sat Jul 4 09:49:45 GMT 2009


Author: ribasushi
Date: 2009-07-04 09:49:44 +0000 (Sat, 04 Jul 2009)
New Revision: 6983

Modified:
   DBIx-Class/0.08/branches/mysql_ansi/lib/DBIx/Class/Storage/DBI/mysql.pm
   DBIx-Class/0.08/branches/mysql_ansi/t/71mysql.t
Log:
Initial set_ansi_mode code - make sure to utilize _do_query instead of dbh->do, so the result is visible in the trace

Modified: DBIx-Class/0.08/branches/mysql_ansi/lib/DBIx/Class/Storage/DBI/mysql.pm
===================================================================
--- DBIx-Class/0.08/branches/mysql_ansi/lib/DBIx/Class/Storage/DBI/mysql.pm	2009-07-04 09:46:57 UTC (rev 6982)
+++ DBIx-Class/0.08/branches/mysql_ansi/lib/DBIx/Class/Storage/DBI/mysql.pm	2009-07-04 09:49:44 UTC (rev 6983)
@@ -20,6 +20,12 @@
   $self->_do_query('SET FOREIGN_KEY_CHECKS = 1');
 }
 
+sub connect_call_set_ansi_mode {
+  my $self = shift;
+  $self->_do_query(q|SET SQL_MODE = 'ANSI,TRADITIONAL'|);
+  $self->_do_query(q|SET SQL_AUTO_IS_NULL = 0|);
+}
+
 sub _dbh_last_insert_id {
   my ($self, $dbh, $source, $col) = @_;
   $dbh->{mysql_insertid};
@@ -79,6 +85,9 @@
 
 This class implements MySQL specific bits of L<DBIx::Class::Storage::DBI>.
 
+It also provides a one-stop macro that sets session variables such that
+MySQL behaves more predictably as far as the SQL standard is concerned.
+
 =head1 AUTHORS
 
 See L<DBIx::Class/CONTRIBUTORS>

Modified: DBIx-Class/0.08/branches/mysql_ansi/t/71mysql.t
===================================================================
--- DBIx-Class/0.08/branches/mysql_ansi/t/71mysql.t	2009-07-04 09:46:57 UTC (rev 6982)
+++ DBIx-Class/0.08/branches/mysql_ansi/t/71mysql.t	2009-07-04 09:49:44 UTC (rev 6983)
@@ -164,10 +164,12 @@
 ##
 ## Only way is to do a SET SQL_AUTO_IS_NULL = 0; on connect
 ## But I'm not sure if we should do this or not (Ash, 2008/06/03)
+#
+# There is now a built-in function to do this, test that everything works
+# with it (ribasushi, 2009/07/03)
 
 NULLINSEARCH: {
-    local $TODO = 'Fix pending in branches/mysql_ansi';
-    my $ansi_schema = DBICTest::Schema->connect ($dsn, $user, $pass);
+    my $ansi_schema = DBICTest::Schema->connect ($dsn, $user, $pass, { on_connect_call => 'set_ansi_mode' });
 
     $ansi_schema->resultset('Artist')->create ({ name => 'last created artist' });
 




More information about the Bast-commits mailing list