[Bast-commits] r6619 - in DBIx-Class/0.08/branches/type_aware_update/lib/DBIx/Class: . Storage

ribasushi at dev.catalyst.perl.org ribasushi at dev.catalyst.perl.org
Thu Jun 11 14:15:53 GMT 2009


Author: ribasushi
Date: 2009-06-11 14:15:53 +0000 (Thu, 11 Jun 2009)
New Revision: 6619

Modified:
   DBIx-Class/0.08/branches/type_aware_update/lib/DBIx/Class/ResultSource.pm
   DBIx-Class/0.08/branches/type_aware_update/lib/DBIx/Class/Row.pm
   DBIx-Class/0.08/branches/type_aware_update/lib/DBIx/Class/Storage/DBI.pm
Log:
Use equality, not comparison

Modified: DBIx-Class/0.08/branches/type_aware_update/lib/DBIx/Class/ResultSource.pm
===================================================================
--- DBIx-Class/0.08/branches/type_aware_update/lib/DBIx/Class/ResultSource.pm	2009-06-11 13:58:50 UTC (rev 6618)
+++ DBIx-Class/0.08/branches/type_aware_update/lib/DBIx/Class/ResultSource.pm	2009-06-11 14:15:53 UTC (rev 6619)
@@ -121,7 +121,7 @@
 Set this to a true or false value (not C<undef>) to explicitly specify
 if this column contains numeric data. This controls how set_column
 decides whether to consider a column dirty after an update: if
-C<is_numeric> is true a numeric comparison C<< <=> >> will take place
+C<is_numeric> is true a numeric comparison C<< != >> will take place
 instead of the usual C<eq>
 
 If not specified the storage class will attempt to figure this out on

Modified: DBIx-Class/0.08/branches/type_aware_update/lib/DBIx/Class/Row.pm
===================================================================
--- DBIx-Class/0.08/branches/type_aware_update/lib/DBIx/Class/Row.pm	2009-06-11 13:58:50 UTC (rev 6618)
+++ DBIx-Class/0.08/branches/type_aware_update/lib/DBIx/Class/Row.pm	2009-06-11 14:15:53 UTC (rev 6619)
@@ -793,7 +793,7 @@
     }
 
     if ($colinfo->{is_numeric}) {
-      $dirty = $old_value <=> $new_value;
+      $dirty = $old_value != $new_value;
     }
     else {
       $dirty = 1;

Modified: DBIx-Class/0.08/branches/type_aware_update/lib/DBIx/Class/Storage/DBI.pm
===================================================================
--- DBIx-Class/0.08/branches/type_aware_update/lib/DBIx/Class/Storage/DBI.pm	2009-06-11 13:58:50 UTC (rev 6618)
+++ DBIx-Class/0.08/branches/type_aware_update/lib/DBIx/Class/Storage/DBI.pm	2009-06-11 14:15:53 UTC (rev 6619)
@@ -1564,7 +1564,7 @@
 Given a datatype from column_info, returns a boolean value indicating if
 the current RDBMS considers it a numeric value. This controls how
 L<DBIx::Class::Row/set_column> decides whether to mark the column as
-dirty - when the datatype is deemed numeric a C<< <=> >> comparison will
+dirty - when the datatype is deemed numeric a C<< != >> comparison will
 be performed instead of the usual C<eq>.
 
 =cut




More information about the Bast-commits mailing list