[Bast-commits] r6105 - DBIx-Class/0.08/branches/count_distinct/t

[arcanez at dev.catalyst.perl.org]

Author: arcanez
Date: 2009-05-02 01:20:04 +0000 (Sat, 02 May 2009)
New Revision: 6105

Modified:
   DBIx-Class/0.08/branches/count_distinct/t/60core.t
   DBIx-Class/0.08/branches/count_distinct/t/73oracle.t
Log:
more fixes to tests

Modified: DBIx-Class/0.08/branches/count_distinct/t/60core.t
===================================================================
--- DBIx-Class/0.08/branches/count_distinct/t/60core.t	2009-05-02 00:33:49 UTC (rev 6104)
+++ DBIx-Class/0.08/branches/count_distinct/t/60core.t	2009-05-02 01:20:04 UTC (rev 6105)
@@ -8,7 +8,7 @@
 
 my $schema = DBICTest->init_schema();
 
-plan tests => 95;
+plan tests => 96;
 
 eval { require DateTime::Format::MySQL };
 my $NO_DTFM = $@ ? 1 : 0;
@@ -247,18 +247,28 @@
   my $tcount = $schema->resultset('Track')->search(
     {},
     {
-      select => [ qw/position title/ ]
+      select => [ qw/position title/ ],
+      distinct => 1,
     }
   );
   is($tcount->count, 13, 'multiple column COUNT DISTINCT ok');
 
-   $tcount = $schema->resultset('Track')->search(
-     {},
-     {
-        group_by => [ qw/position title/ ]
-     }
-   );
-   is($tcount->count, 13, 'multiple column COUNT DISTINCT using column syntax ok');  
+  $tcount = $schema->resultset('Track')->search(
+    {},
+    {
+      columns => [ qw/position title/ ],
+      distinct => 1,
+    }
+  );
+  is($tcount->count, 13, 'multiple column COUNT DISTINCT ok');
+
+  $tcount = $schema->resultset('Track')->search(
+    {},
+    {
+       group_by => [ qw/position title/ ]
+    }
+  );
+  is($tcount->count, 13, 'multiple column COUNT DISTINCT using column syntax ok');  
 }
 
 my $tag_rs = $schema->resultset('Tag')->search(

Modified: DBIx-Class/0.08/branches/count_distinct/t/73oracle.t
===================================================================
--- DBIx-Class/0.08/branches/count_distinct/t/73oracle.t	2009-05-02 00:33:49 UTC (rev 6104)
+++ DBIx-Class/0.08/branches/count_distinct/t/73oracle.t	2009-05-02 01:20:04 UTC (rev 6105)
@@ -106,16 +106,33 @@
 
 # check count distinct with multiple columns
 my $other_track = $schema->resultset('Track')->create({ trackid => 2, cd => 1, position => 1, title => 'Track2' });
+
 my $tcount = $schema->resultset('Track')->search(
-    {},
-    {
-        select => [{count => {distinct => ['position', 'title']}}],
-        as => ['count']
-    }
-  );
+  {},
+  {
+    select => [ qw/position title/ ],
+    distinct => 1,
+  }
+);
+is($tcount->count, 13, 'multiple column COUNT DISTINCT ok');
 
-is($tcount->next->get_column('count'), 2, "multiple column select distinct ok");
+$tcount = $schema->resultset('Track')->search(
+  {},
+  {
+    columns => [ qw/position title/ ],
+    distinct => 1,
+  }
+);
+is($tcount->count, 13, 'multiple column COUNT DISTINCT ok');
 
+$tcount = $schema->resultset('Track')->search(
+  {},
+  { 
+     group_by => [ qw/position title/ ]
+  }
+);
+is($tcount->count, 13, 'multiple column COUNT DISTINCT using column syntax ok');
+
 # test LIMIT support
 for (1..6) {
     $schema->resultset('Artist')->create({ name => 'Artist ' . $_ });