[Bast-commits] r6295 - DBIx-Class/0.08/branches/diamond_relationships/lib/DBIx/Class

[ribasushi at dev.catalyst.perl.org]

Author: ribasushi
Date: 2009-05-18 12:05:31 +0000 (Mon, 18 May 2009)
New Revision: 6295

Modified:
   DBIx-Class/0.08/branches/diamond_relationships/lib/DBIx/Class/ResultSource.pm
Log:
Add a comment about a small resolve_join omission

Modified: DBIx-Class/0.08/branches/diamond_relationships/lib/DBIx/Class/ResultSource.pm
===================================================================
--- DBIx-Class/0.08/branches/diamond_relationships/lib/DBIx/Class/ResultSource.pm	2009-05-18 11:20:59 UTC (rev 6294)
+++ DBIx-Class/0.08/branches/diamond_relationships/lib/DBIx/Class/ResultSource.pm	2009-05-18 12:05:31 UTC (rev 6295)
@@ -1092,8 +1092,14 @@
     unless $seen;
 
   $force_left ||= { force => 0 };
-  $jpath ||= [];
 
+  # This isn't quite right, we should actually dive into $seen and reconstruct
+  # the entire path (the reference entry point would be the join conditional
+  # with depth == current_depth - 1. At this point however nothing depends on
+  # having the entire path, transcending related_resultset, so just leave it
+  # as is, hairy enough already.
+  $jpath ||= [];  
+
   if (ref $join eq 'ARRAY') {
     return
       map {