[Bast-commits] r6398 - in DBIx-Class/0.08/trunk:
lib/DBIx/Class/Storage/DBI/Sybase t
ribasushi at dev.catalyst.perl.org
ribasushi at dev.catalyst.perl.org
Sun May 24 12:12:41 GMT 2009
Author: ribasushi
Date: 2009-05-24 12:12:39 +0000 (Sun, 24 May 2009)
New Revision: 6398
Modified:
DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/Sybase/MSSQL.pm
DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/Sybase/Microsoft_SQL_Server.pm
DBIx-Class/0.08/trunk/t/03podcoverage.t
Log:
Deprecate ::DBI::Sybase::MSSQL
Modified: DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/Sybase/MSSQL.pm
===================================================================
--- DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/Sybase/MSSQL.pm 2009-05-24 09:43:32 UTC (rev 6397)
+++ DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/Sybase/MSSQL.pm 2009-05-24 12:12:39 UTC (rev 6398)
@@ -3,15 +3,32 @@
use strict;
use warnings;
+use Carp::Clan qw/^DBIx::Class/;
+
+carp 'Setting of storage_type is redundant as connections through DBD::Sybase'
+ .' are now properly recognized and reblessed into the appropriate subclass'
+ .' (DBIx::Class::Storage::DBI::Sybase::Microsoft_SQL_Server in the'
+ .' case of MSSQL). Please remove the explicit call to'
+ .q/ $schema->storage_type('::DBI::Sybase::MSSQL')/
+ .', as this storage class has been deprecated in favor of the autodetected'
+ .' ::DBI::Sybase::Microsoft_SQL_Server';
+
+
use base qw/DBIx::Class::Storage::DBI::ODBC::Microsoft_SQL_Server DBIx::Class::Storage::DBI::Sybase/;
1;
=head1 NAME
-DBIx::Class::Storage::DBI::Sybase::MSSQL - Storage::DBI subclass for MSSQL via
-DBD::Sybase
+DBIx::Class::Storage::DBI::Sybase::MSSQL - (DEPRECATED) Legacy storage class for MSSQL via DBD::Sybase
+=head1 NOTE
+
+Connections through DBD::Sybase are now correctly recognized and reblessed
+into the appropriate subclass (L<DBIx::Class::Storage::DBI::Sybase::Microsoft_SQL_Server>
+in the case of MSSQL). Please remove the explicit storage_type setting from your
+schema.
+
=head1 SYNOPSIS
This subclass supports MSSQL connected via L<DBD::Sybase>.
Modified: DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/Sybase/Microsoft_SQL_Server.pm
===================================================================
--- DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/Sybase/Microsoft_SQL_Server.pm 2009-05-24 09:43:32 UTC (rev 6397)
+++ DBIx-Class/0.08/trunk/lib/DBIx/Class/Storage/DBI/Sybase/Microsoft_SQL_Server.pm 2009-05-24 12:12:39 UTC (rev 6398)
@@ -17,11 +17,8 @@
=head1 SYNOPSIS
-This subclass supports MSSQL connected via L<DBD::Sybase>.
+This subclass supports MSSQL server connections via L<DBD::Sybase>.
- $schema->storage_type('::DBI::Sybase::Microsoft_SQL_Server');
- $schema->connect_info('dbi:Sybase:....', ...);
-
=head1 CAVEATS
This storage driver uses L<DBIx::Class::Storage::DBI::NoBindVars> as a base.
Modified: DBIx-Class/0.08/trunk/t/03podcoverage.t
===================================================================
--- DBIx-Class/0.08/trunk/t/03podcoverage.t 2009-05-24 09:43:32 UTC (rev 6397)
+++ DBIx-Class/0.08/trunk/t/03podcoverage.t 2009-05-24 12:12:39 UTC (rev 6398)
@@ -108,6 +108,7 @@
'DBIx::Class::Storage::DBI' => { skip => 1 },
'DBIx::Class::Storage::DBI::DB2' => { skip => 1 },
'DBIx::Class::Storage::DBI::MSSQL' => { skip => 1 },
+ 'DBIx::Class::Storage::DBI::Sybase::MSSQL' => { skip => 1 },
'DBIx::Class::Storage::DBI::ODBC400' => { skip => 1 },
'DBIx::Class::Storage::DBI::ODBC::DB2_400_SQL' => { skip => 1 },
'DBIx::Class::Storage::DBI::Oracle' => { skip => 1 },
More information about the Bast-commits
mailing list