[Bast-commits] r6455 - in DBIx-Class-InflateColumn-FS/1.000/trunk: . t

semifor at dev.catalyst.perl.org semifor at dev.catalyst.perl.org
Sat May 30 01:34:36 GMT 2009


Author: semifor
Date: 2009-05-30 01:34:36 +0000 (Sat, 30 May 2009)
New Revision: 6455

Modified:
   DBIx-Class-InflateColumn-FS/1.000/trunk/Changes
   DBIx-Class-InflateColumn-FS/1.000/trunk/t/01-fs_columns.t
Log:
skip test to accommodate older DBIC releases without make_column_dirty

Modified: DBIx-Class-InflateColumn-FS/1.000/trunk/Changes
===================================================================
--- DBIx-Class-InflateColumn-FS/1.000/trunk/Changes	2009-05-29 16:28:54 UTC (rev 6454)
+++ DBIx-Class-InflateColumn-FS/1.000/trunk/Changes	2009-05-30 01:34:36 UTC (rev 6455)
@@ -1,4 +1,5 @@
 0.01004 2009-05-14
+    - skip test to accommodate older DBIC releases without make_column_dirty
     - don't rely on {_column_data} for deflate values
 
 0.01003 2009-04-17

Modified: DBIx-Class-InflateColumn-FS/1.000/trunk/t/01-fs_columns.t
===================================================================
--- DBIx-Class-InflateColumn-FS/1.000/trunk/t/01-fs_columns.t	2009-05-29 16:28:54 UTC (rev 6454)
+++ DBIx-Class-InflateColumn-FS/1.000/trunk/t/01-fs_columns.t	2009-05-30 01:34:36 UTC (rev 6455)
@@ -100,11 +100,15 @@
 is( $book->cover_image, $cover_image, 'backing filename did not change' );
 isnt( $book->cover_image_2, $cover_image_2, 'backing filename did change for fs_new_on_update column' );
 
-
+SKIP: {
 # ensure FS works with the proposed change for DBIC: make_column_dirty to delete {_column_data}{$column}
-$storage = $book->cover_image;
 
-$book->make_column_dirty('cover_image');
-delete $book->{_column_data}{cover_image};
-$book->update;
-is( $book->cover_image, $storage, 'file backikng filename unchanged')
+    skip 'requires make_column_dirty', 1 unless $book->can('make_column_dirty');
+
+    $storage = $book->cover_image;
+
+    $book->make_column_dirty('cover_image');
+    delete $book->{_column_data}{cover_image};
+    $book->update;
+    is( $book->cover_image, $storage, 'file backikng filename unchanged')
+};




More information about the Bast-commits mailing list