[Bast-commits] r7691 - in DBIx-Class/0.08/trunk: . lib/DBIx

[ribasushi at dev.catalyst.perl.org]

Author: ribasushi
Date: 2009-09-18 12:32:15 +0000 (Fri, 18 Sep 2009)
New Revision: 7691

Modified:
   DBIx-Class/0.08/trunk/Changes
   DBIx-Class/0.08/trunk/Makefile.PL
   DBIx-Class/0.08/trunk/lib/DBIx/Class.pm
Log:
Changes and dev notes in makefile

Modified: DBIx-Class/0.08/trunk/Changes
===================================================================
--- DBIx-Class/0.08/trunk/Changes	2009-09-18 12:25:06 UTC (rev 7690)
+++ DBIx-Class/0.08/trunk/Changes	2009-09-18 12:32:15 UTC (rev 7691)
@@ -25,6 +25,9 @@
         - More informative exception on failing _resolve_relationship
         - Fix unreported rollback exceptions in TxnScopeGuard
         - Fix overly-eager left-join chain enforcing code
+        - Warn about using distinct with an existing group_by
+        - Warn about attempting to $rs->get_column a non-unique column
+          when has_many joins are added to resultset
 
 0.08111 2009-09-06 21:58:00 (UTC)
         - The hashref to connection_info now accepts a 'dbh_maker'

Modified: DBIx-Class/0.08/trunk/Makefile.PL
===================================================================
--- DBIx-Class/0.08/trunk/Makefile.PL	2009-09-18 12:25:06 UTC (rev 7690)
+++ DBIx-Class/0.08/trunk/Makefile.PL	2009-09-18 12:32:15 UTC (rev 7691)
@@ -54,14 +54,18 @@
   'Hash::Merge',              => '0.11',
 );
 
-# when changing also adjust $DBIx::Class::minimum_sqlt_version
-my $sqlt_recommends = '0.11002';
-
+#************************************************************************#
+# Make *ABSOLUTELY SURE* that nothing on this list is a real require,    #
+# since every module listed in %force_requires_if_author is deleted      #
+# from the final META.yml (thus will never make it as a CPAN dependency) #
+#************************************************************************#
 my %force_requires_if_author = (
   %replication_requires,
 
+  # when changing also adjust $DBIx::Class::minimum_sqlt_version
+  'SQL::Translator'           => '0.11002',
+
 #  'Module::Install::Pod::Inherit' => '0.01',
-  'SQL::Translator'           => $sqlt_recommends,
 
   # when changing also adjust version in t/02pod.t
   'Test::Pod'                 => '1.26',
@@ -117,6 +121,11 @@
     ) : ()
   ,
 );
+#************************************************************************#
+# Make *ABSOLUTELY SURE* that nothing on the list aboveis a real require,#
+# since every module listed in %force_requires_if_author is deleted      #
+# from the final META.yml (thus will never make it as a CPAN dependency) #
+#************************************************************************#
 
 
 install_script (qw|

Modified: DBIx-Class/0.08/trunk/lib/DBIx/Class.pm
===================================================================
--- DBIx-Class/0.08/trunk/lib/DBIx/Class.pm	2009-09-18 12:25:06 UTC (rev 7690)
+++ DBIx-Class/0.08/trunk/lib/DBIx/Class.pm	2009-09-18 12:32:15 UTC (rev 7691)
@@ -30,7 +30,7 @@
 $VERSION = eval $VERSION; # numify for warning-free dev releases
 
 # what version of sqlt do we require if deploy() without a ddl_dir is invoked
-# when changing also adjust $sqlt_recommends in Makefile.PL
+# when changing also adjust the corresponding author_require in Makefile.PL
 my $minimum_sqlt_version = '0.11002';
 
 sub MODIFY_CODE_ATTRIBUTES {