[Bast-commits] r9083 - DBIx-Class/0.08/trunk/t

[ribasushi at dev.catalyst.perl.org]

Author: ribasushi
Date: 2010-04-05 20:53:13 +0100 (Mon, 05 Apr 2010)
New Revision: 9083

Modified:
   DBIx-Class/0.08/trunk/t/39load_namespaces_3.t
   DBIx-Class/0.08/trunk/t/51threads.t
   DBIx-Class/0.08/trunk/t/746sybase.t
Log:
Minor test cleanups

Modified: DBIx-Class/0.08/trunk/t/39load_namespaces_3.t
===================================================================
--- DBIx-Class/0.08/trunk/t/39load_namespaces_3.t	2010-04-04 10:57:45 UTC (rev 9082)
+++ DBIx-Class/0.08/trunk/t/39load_namespaces_3.t	2010-04-05 19:53:13 UTC (rev 9083)
@@ -3,25 +3,25 @@
 use strict;
 use warnings;
 use Test::More;
+use Test::Exception;
+use Test::Warn;
 
 use lib qw(t/lib);
 use DBICTest; # do not remove even though it is not used
 
-plan tests => 7;
+lives_ok (sub {
+  warnings_exist ( sub {
+      package DBICNSTestOther;
+      use base qw/DBIx::Class::Schema/;
+      __PACKAGE__->load_namespaces(
+          result_namespace => [ '+DBICNSTest::Rslt', '+DBICNSTest::OtherRslt' ],
+          resultset_namespace => '+DBICNSTest::RSet',
+      );
+    },
+    qr/load_namespaces found ResultSet class C with no corresponding Result class/,
+  );
+});
 
-my $warnings;
-eval {
-    local $SIG{__WARN__} = sub { $warnings .= shift };
-    package DBICNSTestOther;
-    use base qw/DBIx::Class::Schema/;
-    __PACKAGE__->load_namespaces(
-        result_namespace => [ '+DBICNSTest::Rslt', '+DBICNSTest::OtherRslt' ],
-        resultset_namespace => '+DBICNSTest::RSet',
-    );
-};
-ok(!$@) or diag $@;
-like($warnings, qr/load_namespaces found ResultSet class C with no corresponding Result class/);
-
 my $source_a = DBICNSTestOther->source('A');
 isa_ok($source_a, 'DBIx::Class::ResultSource::Table');
 my $rset_a   = DBICNSTestOther->resultset('A');
@@ -34,3 +34,5 @@
 
 my $source_d = DBICNSTestOther->source('D');
 isa_ok($source_d, 'DBIx::Class::ResultSource::Table');
+
+done_testing;

Modified: DBIx-Class/0.08/trunk/t/51threads.t
===================================================================
--- DBIx-Class/0.08/trunk/t/51threads.t	2010-04-04 10:57:45 UTC (rev 9082)
+++ DBIx-Class/0.08/trunk/t/51threads.t	2010-04-05 19:53:13 UTC (rev 9083)
@@ -1,6 +1,9 @@
 use strict;
 use warnings;
+
 use Test::More;
+use Test::Exception;
+
 use Config;
 
 # README: If you set the env var to a number greater than 10,
@@ -38,7 +41,7 @@
 
 my $parent_rs;
 
-eval {
+lives_ok (sub {
     my $dbh = $schema->storage->dbh;
 
     {
@@ -52,8 +55,7 @@
 
     $parent_rs = $schema->resultset('CD')->search({ year => 1901 });
     $parent_rs->next;
-};
-ok(!$@) or diag "Creation eval failed: $@";
+}, 'populate successfull');
 
 my @children;
 while(@children < $num_children) {

Modified: DBIx-Class/0.08/trunk/t/746sybase.t
===================================================================
--- DBIx-Class/0.08/trunk/t/746sybase.t	2010-04-04 10:57:45 UTC (rev 9082)
+++ DBIx-Class/0.08/trunk/t/746sybase.t	2010-04-05 19:53:13 UTC (rev 9083)
@@ -569,12 +569,10 @@
     $row->update({ amount => undef });
   } 'updated a money value to NULL';
 
-  my $null_amount = eval { $rs->find($row->id)->amount };
-  ok(
-    (($null_amount == undef) && (not $@)),
-    'updated money value to NULL round-trip'
-  );
-  diag $@ if $@;
+  lives_ok {
+    my $null_amount = $rs->find($row->id)->amount;
+    is ($null_amount, undef, 'updated money value to NULL round-trip');
+  };
 
 # Test computed columns and timestamps
   $schema->storage->dbh_do (sub {