[Bast-commits] r8605 - in
DBIx-Class/0.08/branches/storage-interbase:
lib/DBIx/Class/Storage/DBI/ODBC t
caelum at dev.catalyst.perl.org
caelum at dev.catalyst.perl.org
Wed Feb 10 22:38:25 GMT 2010
Author: caelum
Date: 2010-02-10 22:38:24 +0000 (Wed, 10 Feb 2010)
New Revision: 8605
Modified:
DBIx-Class/0.08/branches/storage-interbase/lib/DBIx/Class/Storage/DBI/ODBC/Firebird.pm
DBIx-Class/0.08/branches/storage-interbase/t/750firebird.t
Log:
fix savepoints for Firebird ODBC
Modified: DBIx-Class/0.08/branches/storage-interbase/lib/DBIx/Class/Storage/DBI/ODBC/Firebird.pm
===================================================================
--- DBIx-Class/0.08/branches/storage-interbase/lib/DBIx/Class/Storage/DBI/ODBC/Firebird.pm 2010-02-10 22:16:53 UTC (rev 8604)
+++ DBIx-Class/0.08/branches/storage-interbase/lib/DBIx/Class/Storage/DBI/ODBC/Firebird.pm 2010-02-10 22:38:24 UTC (rev 8605)
@@ -43,6 +43,9 @@
# ODBC uses dialect 3 by default, good
sub _set_sql_dialect { 1 }
+# releasing savepoints doesn't work, but that shouldn't matter
+sub _svp_release { 1 }
+
1;
=head1 CAVEATS
@@ -54,6 +57,11 @@
This driver (unlike L<DBD::InterBase>) does not currently support reading or
writing C<TIMESTAMP> values with sub-second precision.
+=item *
+
+Releasing savepoints does not work, but you should still be able to safely use
+savepoints.
+
=back
=head1 AUTHOR
Modified: DBIx-Class/0.08/branches/storage-interbase/t/750firebird.t
===================================================================
--- DBIx-Class/0.08/branches/storage-interbase/t/750firebird.t 2010-02-10 22:16:53 UTC (rev 8604)
+++ DBIx-Class/0.08/branches/storage-interbase/t/750firebird.t 2010-02-10 22:38:24 UTC (rev 8605)
@@ -24,7 +24,7 @@
my $schema;
-foreach my $conn_idx (0..1) {
+foreach my $conn_idx (0..$#info) {
my ($dsn, $user, $pass) = @{ $info[$conn_idx] || [] };
next unless $dsn;
@@ -82,6 +82,10 @@
die "rolling back outer txn";
});
};
+
+ like $@, qr/rolling back outer txn/,
+ 'correct exception for rollback';
+
ok ((not $ars->search({ name => 'in_outer_txn' })->first),
'outer txn rolled back');
More information about the Bast-commits
mailing list