[Bast-commits] r8314 - in DBIx-Class/0.08/branches/null_column_regression: . t/search

[ribasushi at dev.catalyst.perl.org]

Author: ribasushi
Date: 2010-01-15 00:25:10 +0000 (Fri, 15 Jan 2010)
New Revision: 8314

Modified:
   DBIx-Class/0.08/branches/null_column_regression/Changes
   DBIx-Class/0.08/branches/null_column_regression/t/search/related_strip_prefetch.t
Log:
One more sql-test fix and changes

Modified: DBIx-Class/0.08/branches/null_column_regression/Changes
===================================================================
--- DBIx-Class/0.08/branches/null_column_regression/Changes	2010-01-15 00:19:08 UTC (rev 8313)
+++ DBIx-Class/0.08/branches/null_column_regression/Changes	2010-01-15 00:25:10 UTC (rev 8314)
@@ -13,6 +13,8 @@
         - Fix regression in context sensitiveness of deployment_statements
         - Fix regression resulting in overcomplicated query on
           search_related from prefetching resultsets
+        - Fix regression on all-null returning searches (properly switch
+          LEFT JOIN to JOIN in order to distinguish between both cases)
         - Better isolation of RNO-limited queries from the rest of a
           prefetching resultset
         - New MSSQL specific resultset attribute to allow hacky ordered

Modified: DBIx-Class/0.08/branches/null_column_regression/t/search/related_strip_prefetch.t
===================================================================
--- DBIx-Class/0.08/branches/null_column_regression/t/search/related_strip_prefetch.t	2010-01-15 00:19:08 UTC (rev 8313)
+++ DBIx-Class/0.08/branches/null_column_regression/t/search/related_strip_prefetch.t	2010-01-15 00:25:10 UTC (rev 8314)
@@ -31,7 +31,7 @@
       ) me
       JOIN artist artist ON artist.artistid = me.artist
       LEFT JOIN track tracks ON tracks.cd = me.cdid
-      LEFT JOIN tags tags ON tags.cd = me.cdid
+      JOIN tags tags ON tags.cd = me.cdid
     WHERE ( tags.tag IS NOT NULL )
     GROUP BY tags.tagid, tags.cd, tags.tag
   )',