[Bast-commits] r8343 - in DBIx-Class/0.08/branches/prefetch_pager: . lib/DBIx/Class/Storage

[ribasushi at dev.catalyst.perl.org]

Author: ribasushi
Date: 2010-01-17 15:46:02 +0000 (Sun, 17 Jan 2010)
New Revision: 8343

Modified:
   DBIx-Class/0.08/branches/prefetch_pager/Changes
   DBIx-Class/0.08/branches/prefetch_pager/lib/DBIx/Class/Storage/DBIHacks.pm
Log:
Changes

Modified: DBIx-Class/0.08/branches/prefetch_pager/Changes
===================================================================
--- DBIx-Class/0.08/branches/prefetch_pager/Changes	2010-01-17 15:29:20 UTC (rev 8342)
+++ DBIx-Class/0.08/branches/prefetch_pager/Changes	2010-01-17 15:46:02 UTC (rev 8343)
@@ -1,6 +1,9 @@
 Revision history for DBIx::Class
 
         - Perl 5.8.1 is now the minimum supported version
+        - Massive optimization of the join resolution code - now joins
+          will be removed from the resulting SQL if DBIC can prove they
+          are not referenced by anything
         - Subqueries no longer marked experimental
         - might_have/has_one now warn if applied calling class's column
           has is_nullable set to true.

Modified: DBIx-Class/0.08/branches/prefetch_pager/lib/DBIx/Class/Storage/DBIHacks.pm
===================================================================
--- DBIx-Class/0.08/branches/prefetch_pager/lib/DBIx/Class/Storage/DBIHacks.pm	2010-01-17 15:29:20 UTC (rev 8342)
+++ DBIx-Class/0.08/branches/prefetch_pager/lib/DBIx/Class/Storage/DBIHacks.pm	2010-01-17 15:46:02 UTC (rev 8343)
@@ -97,6 +97,7 @@
   }
 
   # construct the inner $from for the subquery
+  # we need to prune first, because this will determine if we need a group_bu below
   my $inner_from = $self->_prune_unused_joins ($from, $inner_select, $where, $inner_attrs);
 
   # if a multi-type join was needed in the subquery - add a group_by to simulate the