[Bast-commits] r9747 - Class-Accessor-Grouped/trunk/t

[ribasushi at dev.catalyst.perl.org]

Author: ribasushi
Date: 2010-10-08 17:10:38 +0100 (Fri, 08 Oct 2010)
New Revision: 9747

Modified:
   Class-Accessor-Grouped/trunk/t/accessors.t
   Class-Accessor-Grouped/trunk/t/accessors_ro.t
   Class-Accessor-Grouped/trunk/t/accessors_wo.t
Log:
Cleanup tests, s/class/obj/ where appropriate

Modified: Class-Accessor-Grouped/trunk/t/accessors.t
===================================================================
--- Class-Accessor-Grouped/trunk/t/accessors.t	2010-10-08 15:50:27 UTC (rev 9746)
+++ Class-Accessor-Grouped/trunk/t/accessors.t	2010-10-08 16:10:38 UTC (rev 9747)
@@ -18,9 +18,19 @@
 
 use AccessorGroups;
 
-my $class = AccessorGroups->new;
+my $obj = AccessorGroups->new;
 
 {
+    my $class = ref $obj;
+    my $name = 'multiple1';
+    my $alias = "_${name}_accessor";
+    my $accessor = $obj->can($name);
+    my $alias_accessor = $obj->can($alias);
+    isnt(sub_name($accessor), '__ANON__', 'accessor is named');
+    isnt(sub_name($alias_accessor), '__ANON__', 'alias is named');
+    is(sub_fullname($accessor), join('::',$class,$name), 'accessor FQ name');
+    is(sub_fullname($alias_accessor), join('::',$class,$alias), 'alias FQ name');
+
     my $warned = 0;
 
     local $SIG{__WARN__} = sub {
@@ -29,25 +39,11 @@
         };
     };
 
-    $class->mk_group_accessors('warnings', 'DESTROY');
+    no warnings qw/once/;
+    local *AccessorGroups::DESTROY = sub {};
 
+    $obj->mk_group_accessors('warnings', 'DESTROY');
     ok($warned);
-
-    # restore non-accessorized DESTROY
-    no warnings;
-    *AccessorGroups::DESTROY = sub {};
-};
-
-{
-  my $class_name = ref $class;
-  my $name = 'multiple1';
-  my $alias = "_${name}_accessor";
-  my $accessor = $class->can($name);
-  my $alias_accessor = $class->can($alias);
-  isnt(sub_name($accessor), '__ANON__', 'accessor is named');
-  isnt(sub_name($alias_accessor), '__ANON__', 'alias is named');
-  is(sub_fullname($accessor), join('::',$class_name,$name), 'accessor FQ name');
-  is(sub_fullname($alias_accessor), join('::',$class_name,$alias), 'alias FQ name');
 }
 
 my $test_accessors = {
@@ -73,28 +69,28 @@
     my $field = $test_accessors->{$name}{custom_field} || $name;
     my $extra = $test_accessors->{$name}{has_extra};
 
-    can_ok($class, $name, $alias);
-    ok(!$class->can($field))
+    can_ok($obj, $name, $alias);
+    ok(!$obj->can($field))
       if $field ne $name;
 
-    is($class->$name, undef);
-    is($class->$alias, undef);
+    is($obj->$name, undef);
+    is($obj->$alias, undef);
 
     # get/set via name
-    is($class->$name('a'), 'a');
-    is($class->$name, 'a');
-    is($class->{$field}, $extra ? 'a Extra tackled on' : 'a');
+    is($obj->$name('a'), 'a');
+    is($obj->$name, 'a');
+    is($obj->{$field}, $extra ? 'a Extra tackled on' : 'a');
 
     # alias gets same as name
-    is($class->$alias, 'a');
+    is($obj->$alias, 'a');
 
     # get/set via alias
-    is($class->$alias('b'), 'b');
-    is($class->$alias, 'b');
-    is($class->{$field}, $extra ? 'b Extra tackled on' : 'b');
+    is($obj->$alias('b'), 'b');
+    is($obj->$alias, 'b');
+    is($obj->{$field}, $extra ? 'b Extra tackled on' : 'b');
 
     # alias gets same as name
-    is($class->$name, 'b');
+    is($obj->$name, 'b');
 };
 
 # important

Modified: Class-Accessor-Grouped/trunk/t/accessors_ro.t
===================================================================
--- Class-Accessor-Grouped/trunk/t/accessors_ro.t	2010-10-08 15:50:27 UTC (rev 9746)
+++ Class-Accessor-Grouped/trunk/t/accessors_ro.t	2010-10-08 16:10:38 UTC (rev 9747)
@@ -18,7 +18,7 @@
 
 use AccessorGroupsRO;
 
-my $class = AccessorGroupsRO->new;
+my $obj = AccessorGroupsRO->new;
 
 {
     my $warned = 0;
@@ -29,13 +29,12 @@
         };
     };
 
-    $class->mk_group_ro_accessors('warnings', 'DESTROY');
+    no warnings qw/once/;
+    local *AccessorGroupsRO::DESTROY = sub {};
 
-    ok($warned);
+    $obj->mk_group_ro_accessors('warnings', 'DESTROY');
 
-    # restore non-accessorized DESTROY
-    no warnings;
-    *AccessorGroupsRO::DESTROY = sub {};
+    ok($warned);
 };
 
 my $test_accessors = {
@@ -59,20 +58,20 @@
     my $alias = "_${name}_accessor";
     my $field = $test_accessors->{$name}{custom_field} || $name;
 
-    can_ok($class, $name, $alias);
+    can_ok($obj, $name, $alias);
 
-    ok(!$class->can($field))
+    ok(!$obj->can($field))
       if $field ne $name;
 
-    is($class->$name, undef);
-    is($class->$alias, undef);
+    is($obj->$name, undef);
+    is($obj->$alias, undef);
 
     # get via name
-    $class->{$field} = 'a';
-    is($class->$name, 'a');
+    $obj->{$field} = 'a';
+    is($obj->$name, 'a');
 
     # alias gets same as name
-    is($class->$alias, 'a');
+    is($obj->$alias, 'a');
 
     my $ro_regex = $test_accessors->{$name}{is_xs}
         ? qr/Usage\:.+$name.*\(self\)/
@@ -81,16 +80,16 @@
 
     # die on set via name/alias
     throws_ok {
-        $class->$name('b');
+        $obj->$name('b');
     } $ro_regex;
 
     throws_ok {
-        $class->$alias('b');
+        $obj->$alias('b');
     } $ro_regex;
 
     # value should be unchanged
-    is($class->$name, 'a');
-    is($class->$alias, 'a');
+    is($obj->$name, 'a');
+    is($obj->$alias, 'a');
 };
 
 #important

Modified: Class-Accessor-Grouped/trunk/t/accessors_wo.t
===================================================================
--- Class-Accessor-Grouped/trunk/t/accessors_wo.t	2010-10-08 15:50:27 UTC (rev 9746)
+++ Class-Accessor-Grouped/trunk/t/accessors_wo.t	2010-10-08 16:10:38 UTC (rev 9747)
@@ -18,7 +18,7 @@
 
 use AccessorGroupsWO;
 
-my $class = AccessorGroupsWO->new;
+my $obj = AccessorGroupsWO->new;
 
 {
     my $warned = 0;
@@ -29,13 +29,11 @@
         };
     };
 
-    $class->mk_group_wo_accessors('warnings', 'DESTROY');
+    no warnings qw/once/;
+    local *AccessorGroupsWO::DESTROY = sub {};
 
+    $obj->mk_group_wo_accessors('warnings', 'DESTROY');
     ok($warned);
-
-    # restore non-accessorized DESTROY
-    no warnings;
-    *AccessorGroupsWO::DESTROY = sub {};
 };
 
 my $test_accessors = {
@@ -59,18 +57,18 @@
     my $alias = "_${name}_accessor";
     my $field = $test_accessors->{$name}{custom_field} || $name;
 
-    can_ok($class, $name, $alias);
+    can_ok($obj, $name, $alias);
 
-    ok(!$class->can($field))
+    ok(!$obj->can($field))
       if $field ne $name;
 
     # set via name
-    is($class->$name('a'), 'a');
-    is($class->{$field}, 'a');
+    is($obj->$name('a'), 'a');
+    is($obj->{$field}, 'a');
 
     # alias sets same as name
-    is($class->$alias('b'), 'b');
-    is($class->{$field}, 'b');
+    is($obj->$alias('b'), 'b');
+    is($obj->{$field}, 'b');
 
     my $wo_regex = $test_accessors->{$name}{is_xs}
         ? qr/Usage\:.+$name.*\(self, newvalue\)/
@@ -79,11 +77,11 @@
 
     # die on get via name/alias
     throws_ok {
-        $class->$name;
+        $obj->$name;
     } $wo_regex;
 
     throws_ok {
-        $class->$alias;
+        $obj->$alias;
     } $wo_regex;
 };