[Bast-commits] r9759 - Class-Accessor-Grouped/trunk/lib/Class/Accessor

ribasushi at dev.catalyst.perl.org ribasushi at dev.catalyst.perl.org
Mon Oct 11 07:37:40 GMT 2010


Author: ribasushi
Date: 2010-10-11 08:37:40 +0100 (Mon, 11 Oct 2010)
New Revision: 9759

Modified:
   Class-Accessor-Grouped/trunk/lib/Class/Accessor/Grouped.pm
Log:
Put back the private accessor installer method, there are overrides in the wild

Modified: Class-Accessor-Grouped/trunk/lib/Class/Accessor/Grouped.pm
===================================================================
--- Class-Accessor-Grouped/trunk/lib/Class/Accessor/Grouped.pm	2010-10-11 07:34:48 UTC (rev 9758)
+++ Class-Accessor-Grouped/trunk/lib/Class/Accessor/Grouped.pm	2010-10-11 07:37:40 UTC (rev 9759)
@@ -137,7 +137,11 @@
     };
 };
 
-my $install_group_accessors = sub {
+# Yes this method is undocumented
+# Yes it should be a private coderef like the one above it
+# No we can't do that (yet) because the DBIC-CDBI compat layer overrides it
+# %$*@!?&!&#*$!!!
+sub _mk_group_accessors {
     my($self, $maker, $group, @fields) = @_;
     my $class = Scalar::Util::blessed $self || $self;
 
@@ -217,7 +221,7 @@
 sub mk_group_accessors {
   my ($self, $group, @fields) = @_;
 
-  $self->$install_group_accessors('make_group_accessor', $group, @fields);
+  $self->_mk_group_accessors('make_group_accessor', $group, @fields);
   return;
 }
 
@@ -240,7 +244,7 @@
 sub mk_group_ro_accessors {
     my($self, $group, @fields) = @_;
 
-    $self->$install_group_accessors('make_group_ro_accessor', $group, @fields);
+    $self->_mk_group_accessors('make_group_ro_accessor', $group, @fields);
 }
 
 =head2 mk_group_wo_accessors
@@ -262,7 +266,7 @@
 sub mk_group_wo_accessors {
     my($self, $group, @fields) = @_;
 
-    $self->$install_group_accessors('make_group_wo_accessor', $group, @fields);
+    $self->_mk_group_accessors('make_group_wo_accessor', $group, @fields);
 }
 
 =head2 make_group_accessor




More information about the Bast-commits mailing list