[Catalyst-commits] r6585 - in trunk/Catalyst-Runtime: . lib

[marcus at dev.catalyst.perl.org]

Author: marcus
Date: 2007-07-20 13:30:44 +0100 (Fri, 20 Jul 2007)
New Revision: 6585

Modified:
   trunk/Catalyst-Runtime/Changes
   trunk/Catalyst-Runtime/lib/Catalyst.pm
Log:
add warning in uri_for for undefined args

Modified: trunk/Catalyst-Runtime/Changes
===================================================================
--- trunk/Catalyst-Runtime/Changes	2007-07-19 18:50:01 UTC (rev 6584)
+++ trunk/Catalyst-Runtime/Changes	2007-07-20 12:30:44 UTC (rev 6585)
@@ -1,13 +1,12 @@
 This file documents the revision history for Perl extension Catalyst.
 
-X.XXXX
+5.7008
+	- add undef warning for uri_for
         - Fix bug where a nested component would be setup twice
         - Make ensure_class_loaded behave better with malformed class name
-        - Make _register_plugin use ensure_class_loaded
+	- Make _register_plugin use ensure_class_loaded
         - Remove 'Argument "??" isn't numeric in sprintf' warning
           (Emanuele Zeppieri)
-
-5.7008
         - Fixed a bug where Content-Length could be set to 0 if a filehandle
           object in $c->response->body did not report a size.
         - Fixed issue where development server running in fork mode did not

Modified: trunk/Catalyst-Runtime/lib/Catalyst.pm
===================================================================
--- trunk/Catalyst-Runtime/lib/Catalyst.pm	2007-07-19 18:50:01 UTC (rev 6584)
+++ trunk/Catalyst-Runtime/lib/Catalyst.pm	2007-07-20 12:30:44 UTC (rev 6585)
@@ -931,6 +931,7 @@
     my $params =
       ( scalar @args && ref $args[$#args] eq 'HASH' ? pop @args : {} );
 
+    carp "uri_for called with undef argument" if grep { ! defined $_ } @args;
     s/([^$URI::uric])/$URI::Escape::escapes{$1}/go for @args;
 
     unshift(@args, $path);