[Catalyst-commits] r6211 - in trunk/Catalyst-Runtime: . t

[andyg at dev.catalyst.perl.org]

Author: andyg
Date: 2007-03-27 19:34:35 +0100 (Tue, 27 Mar 2007)
New Revision: 6211

Modified:
   trunk/Catalyst-Runtime/Changes
   trunk/Catalyst-Runtime/Makefile.PL
   trunk/Catalyst-Runtime/t/live_engine_request_parameters.t
Log:
Require HTTP::Body 0.9, added a few tests to check that blank params work properly

Modified: trunk/Catalyst-Runtime/Changes
===================================================================
--- trunk/Catalyst-Runtime/Changes	2007-03-27 18:32:30 UTC (rev 6210)
+++ trunk/Catalyst-Runtime/Changes	2007-03-27 18:34:35 UTC (rev 6211)
@@ -4,8 +4,10 @@
         - Sending SIGHUP to the dev server will now cause it to restart.
         - Allow "0" for a path in uri_for.
         - Performance improvements to uri_for by inlining encoding.
-        - Updated HTTP::Body dependency to 0.8 to handle the case where IE sometimes
-          sends an extra CRLF after a POST body.
+        - Updated HTTP::Body dependency to 0.9 which fixes the following issues:
+          * Handle when IE sometimes sends an extra CRLF after the POST body.
+          * Empty fields in multipart/form-data POSTs are no longer ignored.
+          * Uploaded files with the name "0" are no longer ignored.
 
 5.7007  2007-03-13 14:18:00
         - Performance and stability improvements to the built-in HTTP server.

Modified: trunk/Catalyst-Runtime/Makefile.PL
===================================================================
--- trunk/Catalyst-Runtime/Makefile.PL	2007-03-27 18:32:30 UTC (rev 6210)
+++ trunk/Catalyst-Runtime/Makefile.PL	2007-03-27 18:34:35 UTC (rev 6211)
@@ -14,7 +14,7 @@
 requires 'Data::Dump';
 requires 'File::Modified';
 requires 'HTML::Entities';
-requires 'HTTP::Body'    => '0.8';
+requires 'HTTP::Body'    => '0.9';
 requires 'HTTP::Headers' => '1.64';
 requires 'HTTP::Request';
 requires 'HTTP::Response';

Modified: trunk/Catalyst-Runtime/t/live_engine_request_parameters.t
===================================================================
--- trunk/Catalyst-Runtime/t/live_engine_request_parameters.t	2007-03-27 18:32:30 UTC (rev 6210)
+++ trunk/Catalyst-Runtime/t/live_engine_request_parameters.t	2007-03-27 18:34:35 UTC (rev 6211)
@@ -6,7 +6,7 @@
 use FindBin;
 use lib "$FindBin::Bin/lib";
 
-use Test::More tests => 28;
+use Test::More tests => 29;
 use Catalyst::Test 'TestApp';
 
 use Catalyst::Request;
@@ -41,8 +41,9 @@
     my $creq;
 
     my $parameters = {
-        'a' => [qw(A b C d E f G)],
-        '%' => [ '%', '"', '& - &' ],
+        'a'     => [qw(A b C d E f G)],
+        '%'     => [ '%', '"', '& - &' ],
+        'blank' => '',
     };
 
     my $request = POST(
@@ -78,7 +79,8 @@
     my $creq;
 
     my $parameters = {
-        'url' => 'http://www.google.com',
+        'url'   => 'http://www.google.com',
+        'blank' => '',
     };
 
     my $request = POST( 'http://localhost/dump/request',
@@ -96,7 +98,8 @@
     my $creq;
     
     my $parameters = {
-        a => 1,
+        a     => 1,
+        blank => '',
     };
 
     my $request = POST(
@@ -108,6 +111,7 @@
     ok( my $response = request($request), 'Request' );
     ok( eval '$creq = ' . $response->content, 'Unserialize Catalyst::Request' );
     is( $creq->{uri}->query, 'query_string', 'Catalyst::Request POST query_string' );
+    is_deeply( $creq->{parameters}, $parameters, 'Catalyst::Request parameters' );
     
     ok( $response = request('http://localhost/dump/request/a/b?x=1&y=1&z=1'), 'Request' );
     ok( eval '$creq = ' . $response->content, 'Unserialize Catalyst::Request' );