[Catalyst-commits] r6242 - in trunk/Catalyst-Runtime: . lib/Catalyst t t/lib/TestApp/Controller/Action/Chained

[bricas at dev.catalyst.perl.org]

Author: bricas
Date: 2007-03-30 15:11:27 +0100 (Fri, 30 Mar 2007)
New Revision: 6242

Removed:
   trunk/Catalyst-Runtime/t/lib/TestApp/Controller/Action/Chained/PathPrefix.pm
Modified:
   trunk/Catalyst-Runtime/Changes
   trunk/Catalyst-Runtime/lib/Catalyst/Controller.pm
   trunk/Catalyst-Runtime/t/live_component_controller_action_chained.t
Log:
revert PathPrefix from trunk

Modified: trunk/Catalyst-Runtime/Changes
===================================================================
--- trunk/Catalyst-Runtime/Changes	2007-03-29 20:03:24 UTC (rev 6241)
+++ trunk/Catalyst-Runtime/Changes	2007-03-30 14:11:27 UTC (rev 6242)
@@ -14,7 +14,6 @@
         - Added $c->request->keywords for getting the keywords (a query string with
           no parameters).
         - Sending SIGHUP to the dev server will now cause it to restart.
-        - Added PathPrefix attribute
         - Allow "0" for a path in uri_for.
 
 5.7007  2007-03-13 14:18:00

Modified: trunk/Catalyst-Runtime/lib/Catalyst/Controller.pm
===================================================================
--- trunk/Catalyst-Runtime/lib/Catalyst/Controller.pm	2007-03-29 20:03:24 UTC (rev 6241)
+++ trunk/Catalyst-Runtime/lib/Catalyst/Controller.pm	2007-03-30 14:11:27 UTC (rev 6242)
@@ -292,11 +292,6 @@
     return ( 'ActionClass', $value );
 }
 
-sub _parse_PathPrefix_attr {
-    my ( $self, $c, $name, $value ) = @_;
-    return PathPart => $self->path_prefix;
-}
-
 1;
 
 __END__

Deleted: trunk/Catalyst-Runtime/t/lib/TestApp/Controller/Action/Chained/PathPrefix.pm
===================================================================
--- trunk/Catalyst-Runtime/t/lib/TestApp/Controller/Action/Chained/PathPrefix.pm	2007-03-29 20:03:24 UTC (rev 6241)
+++ trunk/Catalyst-Runtime/t/lib/TestApp/Controller/Action/Chained/PathPrefix.pm	2007-03-30 14:11:27 UTC (rev 6242)
@@ -1,12 +0,0 @@
-package TestApp::Controller::Action::Chained::PathPrefix;
-
-use strict;
-use warnings;
-
-use base qw/Catalyst::Controller/;
-
-# this is kinda the same thing as: sub instance : Path {}
-# it should respond to: /action/chained/pathprefix/*
-sub instance : Chained('/') PathPrefix Args(1) { }
-
-1;

Modified: trunk/Catalyst-Runtime/t/live_component_controller_action_chained.t
===================================================================
--- trunk/Catalyst-Runtime/t/live_component_controller_action_chained.t	2007-03-29 20:03:24 UTC (rev 6241)
+++ trunk/Catalyst-Runtime/t/live_component_controller_action_chained.t	2007-03-30 14:11:27 UTC (rev 6242)
@@ -10,7 +10,7 @@
 
 BEGIN { $iters = $ENV{CAT_BENCH_ITERS} || 1; }
 
-use Test::More tests => 112*$iters;
+use Test::More tests => 109*$iters;
 use Catalyst::Test 'TestApp';
 
 if ( $ENV{CAT_BENCHMARK} ) {
@@ -766,22 +766,4 @@
         is( $response->content, '; ', 'Content OK' );
     }
 
-    #
-    #   PathPrefix
-    #
-    {
-        my @expected = qw[
-          TestApp::Controller::Action::Chained->begin
-          TestApp::Controller::Action::Chained::PathPrefix->instance
-          TestApp::Controller::Action::Chained->end
-        ];
-
-        my $expected = join( ", ", @expected );
-
-        ok( my $response = request('http://localhost/action/chained/pathprefix/1'),
-            "PathPrefix (as an endpoint)" );
-        is( $response->header('X-Catalyst-Executed'),
-            $expected, 'Executed actions' );
-        is( $response->content, '; 1', 'Content OK' );
-    }
 }