[Catalyst-commits] r7101 - in Catalyst-Runtime/5.70/trunk: lib/Catalyst t

[miyagawa at dev.catalyst.perl.org]

Author: miyagawa
Date: 2007-11-09 05:03:54 +0000 (Fri, 09 Nov 2007)
New Revision: 7101

Modified:
   Catalyst-Runtime/5.70/trunk/lib/Catalyst/Engine.pm
   Catalyst-Runtime/5.70/trunk/t/live_engine_request_parameters.t
Log:
fixed a bug in ?q=bar=baz query parameter

Modified: Catalyst-Runtime/5.70/trunk/lib/Catalyst/Engine.pm
===================================================================
--- Catalyst-Runtime/5.70/trunk/lib/Catalyst/Engine.pm	2007-11-09 00:24:32 UTC (rev 7100)
+++ Catalyst-Runtime/5.70/trunk/lib/Catalyst/Engine.pm	2007-11-09 05:03:54 UTC (rev 7101)
@@ -458,7 +458,7 @@
         
         my ($param, $value) 
             = map { $self->unescape_uri($_) }
-              split( /=/, $item );
+              split( /=/, $item, 2 );
           
         $param = $self->unescape_uri($item) unless defined $param;
         

Modified: Catalyst-Runtime/5.70/trunk/t/live_engine_request_parameters.t
===================================================================
--- Catalyst-Runtime/5.70/trunk/t/live_engine_request_parameters.t	2007-11-09 00:24:32 UTC (rev 7100)
+++ Catalyst-Runtime/5.70/trunk/t/live_engine_request_parameters.t	2007-11-09 05:03:54 UTC (rev 7101)
@@ -6,7 +6,7 @@
 use FindBin;
 use lib "$FindBin::Bin/lib";
 
-use Test::More tests => 35;
+use Test::More tests => 40;
 use Catalyst::Test 'TestApp';
 
 use Catalyst::Request;
@@ -48,7 +48,17 @@
 
 {
     my $creq;
+    ok( my $response = request("http://localhost/dump/request?q=foo=bar"),
+        'Request' );
+    ok( $response->is_success, 'Response Successful 2xx' );
+    is( $response->content_type, 'text/plain', 'Response Content-Type' );
+    ok( eval '$creq = ' . $response->content );
+    is $creq->{parameters}->{q}, 'foo=bar', '= not ignored';
+}
 
+{
+    my $creq;
+
     my $parameters = {
         'a'     => [qw(A b C d E f G)],
         '%'     => [ '%', '"', '& - &' ],