[Catalyst-commits] r8907 - in Catalyst-Runtime/5.80/trunk: . t/aggregate

[t0m at dev.catalyst.perl.org]

Author: t0m
Date: 2008-12-18 00:53:44 +0000 (Thu, 18 Dec 2008)
New Revision: 8907

Modified:
   Catalyst-Runtime/5.80/trunk/Changes
   Catalyst-Runtime/5.80/trunk/t/aggregate/live_engine_request_uploads.t
Log:
Test for basename fixes

Modified: Catalyst-Runtime/5.80/trunk/Changes
===================================================================
--- Catalyst-Runtime/5.80/trunk/Changes	2008-12-18 00:52:40 UTC (rev 8906)
+++ Catalyst-Runtime/5.80/trunk/Changes	2008-12-18 00:53:44 UTC (rev 8907)
@@ -1,5 +1,8 @@
 # This file documents the revision history for Perl extension Catalyst.
 
+        - Fix bug causing Catalyst::Request::Upload's basename method
+          to return undef (t0m)
+          - Test for this (Carl Franks)
         - Fix loading of classes which do not define any symbols to not
           die, as it didn't in 5.70 (t0m)
           - Test for this (t0m)
@@ -20,7 +23,6 @@
           Catalyst::Engine::CGI: _header_buf
           Catalyst::Engine::HTTP: options, _keepalive, _write_error
           Catalyst::Request: _path
-          Catalyst::Request::Upload: basename
           Catalyst::Stats: tree
           (t0m)
         - Fix issues in Catalyst::Controller::WrapCGI 

Modified: Catalyst-Runtime/5.80/trunk/t/aggregate/live_engine_request_uploads.t
===================================================================
--- Catalyst-Runtime/5.80/trunk/t/aggregate/live_engine_request_uploads.t	2008-12-18 00:52:40 UTC (rev 8906)
+++ Catalyst-Runtime/5.80/trunk/t/aggregate/live_engine_request_uploads.t	2008-12-18 00:53:44 UTC (rev 8907)
@@ -6,7 +6,7 @@
 use FindBin;
 use lib "$FindBin::Bin/../lib";
 
-use Test::More tests => 101;
+use Test::More tests => 105;
 use Catalyst::Test 'TestApp';
 
 use Catalyst::Request;
@@ -134,6 +134,7 @@
         is( $upload->type, $part->content_type, 'Upload Content-Type' );
         is( $upload->filename, $parameters{filename}, 'Upload filename' );
         is( $upload->size, length( $part->content ), 'Upload Content-Length' );
+        is( $upload->basename, $parameters{filename}, 'Upload basename' );
 
         SKIP:
         {
@@ -276,6 +277,7 @@
         is( $upload->type, $part->content_type, 'Upload Content-Type' );
         is( $upload->size, length( $part->content ), 'Upload Content-Length' );
         is( $upload->filename, 'catalyst_130pix.gif', 'Upload Filename' );
+        is( $upload->basename, 'catalyst_130pix.gif', 'Upload basename' );
         
         SKIP:
         {