[Catalyst-commits] r8939 - in Catalyst-Runtime/5.80/trunk: . lib t

[t0m at dev.catalyst.perl.org]

Author: t0m
Date: 2008-12-24 10:15:29 +0000 (Wed, 24 Dec 2008)
New Revision: 8939

Modified:
   Catalyst-Runtime/5.80/trunk/Changes
   Catalyst-Runtime/5.80/trunk/TODO
   Catalyst-Runtime/5.80/trunk/lib/Catalyst.pm
   Catalyst-Runtime/5.80/trunk/t/plugin_new_method_backcompat.t
Log:
Fix stringification of dispatcher and engine in debug output

Modified: Catalyst-Runtime/5.80/trunk/Changes
===================================================================
--- Catalyst-Runtime/5.80/trunk/Changes	2008-12-24 06:00:08 UTC (rev 8938)
+++ Catalyst-Runtime/5.80/trunk/Changes	2008-12-24 10:15:29 UTC (rev 8939)
@@ -1,5 +1,7 @@
 # This file documents the revision history for Perl extension Catalyst.
 
+        - Make debug output show class name for the engine and dispatcher
+          rather than the stringified ref. (t0m)
         - Make MyApp immutable at the end of the scope after the setup
           method is called, fixing issues with plugins which have their 
           own new methods by inlining a constructor on MyApp (t0m)

Modified: Catalyst-Runtime/5.80/trunk/TODO
===================================================================
--- Catalyst-Runtime/5.80/trunk/TODO	2008-12-24 06:00:08 UTC (rev 8938)
+++ Catalyst-Runtime/5.80/trunk/TODO	2008-12-24 10:15:29 UTC (rev 8939)
@@ -20,7 +20,6 @@
 
   - Fix memory leaks (I already tried Devel::Leak::Object, but no joy).
 
-
 Cleanups:
 
   - Catalyst-Plugin-Authorization-ACL, Can't locate object method "tree" 

Modified: Catalyst-Runtime/5.80/trunk/lib/Catalyst.pm
===================================================================
--- Catalyst-Runtime/5.80/trunk/lib/Catalyst.pm	2008-12-24 06:00:08 UTC (rev 8938)
+++ Catalyst-Runtime/5.80/trunk/lib/Catalyst.pm	2008-12-24 10:15:29 UTC (rev 8939)
@@ -973,8 +973,8 @@
         my $engine     = $class->engine;
         my $home       = $class->config->{home};
 
-        $class->log->debug(qq/Loaded dispatcher "$dispatcher"/);
-        $class->log->debug(qq/Loaded engine "$engine"/);
+        $class->log->debug(sprintf(q/Loaded dispatcher "%s"/, blessed($dispatcher)));
+        $class->log->debug(sprintf(q/Loaded engine "%s"/, blessed($engine)));
 
         $home
           ? ( -d $home )

Modified: Catalyst-Runtime/5.80/trunk/t/plugin_new_method_backcompat.t
===================================================================
--- Catalyst-Runtime/5.80/trunk/t/plugin_new_method_backcompat.t	2008-12-24 06:00:08 UTC (rev 8938)
+++ Catalyst-Runtime/5.80/trunk/t/plugin_new_method_backcompat.t	2008-12-24 10:15:29 UTC (rev 8939)
@@ -13,5 +13,6 @@
 use lib "$FindBin::Bin/lib";use Test::More tests => 3;
 
 use Catalyst::Test qw/TestAppPluginWithNewMethod/; # 1 test for adding a modifer not throwing.
+BEGIN { warn("COMPILE TIME finished use of Catalyst::Test"); }
 ok request('/foo')->is_success; 
 is $TestAppPluginWithNewMethod::MODIFIER_FIRED, 1, 'Before modifier was fired correctly.';