[Catalyst-commits] r8958 - in Catalyst-Runtime/5.80/trunk: . lib/Catalyst t/aggregate

[t0m at dev.catalyst.perl.org]

Author: t0m
Date: 2008-12-27 18:08:02 +0000 (Sat, 27 Dec 2008)
New Revision: 8958

Modified:
   Catalyst-Runtime/5.80/trunk/Changes
   Catalyst-Runtime/5.80/trunk/lib/Catalyst/Request.pm
   Catalyst-Runtime/5.80/trunk/t/aggregate/live_engine_request_body.t
Log:
Fix C::Request disparity between _body and body accessors, TODO test now passes.

Modified: Catalyst-Runtime/5.80/trunk/Changes
===================================================================
--- Catalyst-Runtime/5.80/trunk/Changes	2008-12-27 17:25:07 UTC (rev 8957)
+++ Catalyst-Runtime/5.80/trunk/Changes	2008-12-27 18:08:02 UTC (rev 8958)
@@ -1,8 +1,8 @@
 # This file documents the revision history for Perl extension Catalyst.
 
-        - Add TODO tests for calling $c->req->body from inside an overridden
-          prepare_action method in a plugin, as used by 
-          Catalyst::Plugin::Server (t0m)
+        - Fix calling $c->req->body from inside an overridden prepare_action
+          method in a plugin, as used by Catalyst::Plugin::Server (t0m)
+          - Test for this (t0m)
         - Fix assignment to Catalyst::Dispatcher's preload_dispatch_types and
           postload_dispatch_types attributes - assigning a list should later 
           return a listref. Fixes Catalyst::Plugin::Server. (t0m)

Modified: Catalyst-Runtime/5.80/trunk/lib/Catalyst/Request.pm
===================================================================
--- Catalyst-Runtime/5.80/trunk/lib/Catalyst/Request.pm	2008-12-27 17:25:07 UTC (rev 8957)
+++ Catalyst-Runtime/5.80/trunk/lib/Catalyst/Request.pm	2008-12-27 18:08:02 UTC (rev 8958)
@@ -96,8 +96,9 @@
   },
 );
 
-has body => (
-  is => 'rw'
+has _body => (
+  is => 'rw',
+  accessor => 'body',
 );
 
 before body => sub {

Modified: Catalyst-Runtime/5.80/trunk/t/aggregate/live_engine_request_body.t
===================================================================
--- Catalyst-Runtime/5.80/trunk/t/aggregate/live_engine_request_body.t	2008-12-27 17:25:07 UTC (rev 8957)
+++ Catalyst-Runtime/5.80/trunk/t/aggregate/live_engine_request_body.t	2008-12-27 18:08:02 UTC (rev 8958)
@@ -86,9 +86,6 @@
 
     ok( my $response = request($request), 'Request' );
     ok( $response->is_success, 'Response Successful 2xx' );
-    TODO: {
-        local $TODO = 'On demand request body parsing in prepare_action broken';
-        like( $response->content, qr/^[1-9]/, 'Has body' );
-    }
+    like( $response->content, qr/^[1-9]/, 'Has body' );
 }