[Catalyst-commits] r7671 - in
Catalyst-Runtime/5.80/branches/moose/lib/Catalyst: . Request
groditi at dev.catalyst.perl.org
groditi at dev.catalyst.perl.org
Sat May 3 20:33:51 BST 2008
Author: groditi
Date: 2008-05-03 20:33:51 +0100 (Sat, 03 May 2008)
New Revision: 7671
Modified:
Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Action.pm
Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/ActionContainer.pm
Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Dispatcher.pm
Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Log.pm
Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Request.pm
Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Request/Upload.pm
Log:
whitespace changes for attributes
Modified: Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Action.pm
===================================================================
--- Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Action.pm 2008-05-02 14:29:06 UTC (rev 7670)
+++ Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Action.pm 2008-05-03 19:33:51 UTC (rev 7671)
@@ -19,12 +19,12 @@
use Moose;
-has class => (is => 'rw');
-has namespace => (is => 'rw');
-has 'reverse' => (is => 'rw');
-has attributes => (is => 'rw');
-has name => (is => 'rw');
-has code => (is => 'rw');
+has class => (is => 'rw');
+has namespace => (is => 'rw');
+has 'reverse' => (is => 'rw');
+has attributes => (is => 'rw');
+has name => (is => 'rw');
+has code => (is => 'rw');
no Moose;
Modified: Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/ActionContainer.pm
===================================================================
--- Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/ActionContainer.pm 2008-05-02 14:29:06 UTC (rev 7670)
+++ Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/ActionContainer.pm 2008-05-03 19:33:51 UTC (rev 7671)
@@ -24,7 +24,7 @@
);
-has part => (is => 'rw', required => 1, lazy => 1, default => sub { {} });
+has part => (is => 'rw', required => 1, lazy => 1, default => sub { {} });
has actions => (is => 'rw', required => 1, lazy => 1, default => sub { {} });
around 'new' => sub {
Modified: Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Dispatcher.pm
===================================================================
--- Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Dispatcher.pm 2008-05-02 14:29:06 UTC (rev 7670)
+++ Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Dispatcher.pm 2008-05-03 19:33:51 UTC (rev 7671)
@@ -18,21 +18,22 @@
use overload '""' => sub { return ref(shift) }, fallback => 1;
+#do these belong as package vars or should we build these via a builder method?
# Preload these action types
our @PRELOAD = qw/Index Path Regex/;
# Postload these action types
our @POSTLOAD = qw/Default/;
-has _tree => (is => 'rw');
-has _dispatch_types => (is => 'rw');
-has _registered_dispatch_types => (is => 'rw');
-has _method_action_class => (is => 'rw');
-has _action_container_class => (is => 'rw');
-has preload_dispatch_types => (is => 'rw', required => 1, lazy => 1, default => sub { [@PRELOAD] });
-has postload_dispatch_types => (is => 'rw', required => 1, lazy => 1, default => sub { [@POSTLOAD] });
-has _action_hash => (is => 'rw', required => 1, lazy => 1, default => sub { {} });
-has _container_hash => (is => 'rw', required => 1, lazy => 1, default => sub { {} });
+has _tree => (is => 'rw');
+has _dispatch_types => (is => 'rw');
+has _registered_dispatch_types => (is => 'rw');
+has _method_action_class => (is => 'rw');
+has _action_container_class => (is => 'rw');
+has preload_dispatch_types => (is => 'rw', required => 1, lazy => 1, default => sub { [@PRELOAD] });
+has postload_dispatch_types => (is => 'rw', required => 1, lazy => 1, default => sub { [@POSTLOAD] });
+has _action_hash => (is => 'rw', required => 1, lazy => 1, default => sub { {} });
+has _container_hash => (is => 'rw', required => 1, lazy => 1, default => sub { {} });
no Moose;
Modified: Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Log.pm
===================================================================
--- Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Log.pm 2008-05-02 14:29:06 UTC (rev 7670)
+++ Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Log.pm 2008-05-03 19:33:51 UTC (rev 7671)
@@ -6,7 +6,7 @@
our %LEVELS = ();
has level => (is => 'rw');
-has _body => (is => 'rw');
+has _body => (is => 'rw');
has abort => (is => 'rw');
{
Modified: Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Request/Upload.pm
===================================================================
--- Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Request/Upload.pm 2008-05-02 14:29:06 UTC (rev 7670)
+++ Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Request/Upload.pm 2008-05-03 19:33:51 UTC (rev 7671)
@@ -7,12 +7,12 @@
use IO::File ();
use File::Spec::Unix;
-has filename => (is => 'rw');
-has headers => (is => 'rw');
-has size => (is => 'rw');
-has tempname => (is => 'rw');
-has type => (is => 'rw');
-has basename => (is => 'rw');
+has filename => (is => 'rw');
+has headers => (is => 'rw');
+has size => (is => 'rw');
+has tempname => (is => 'rw');
+has type => (is => 'rw');
+has basename => (is => 'rw');
has fh => (
is => 'rw',
Modified: Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Request.pm
===================================================================
--- Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Request.pm 2008-05-02 14:29:06 UTC (rev 7670)
+++ Catalyst-Runtime/5.80/branches/moose/lib/Catalyst/Request.pm 2008-05-03 19:33:51 UTC (rev 7671)
@@ -9,20 +9,20 @@
use Moose;
-has action => (is => 'rw');
-has address => (is => 'rw');
-has arguments => (is => 'rw', default => sub { [] });
-has cookies => (is => 'rw', default => sub { {} });
-has query_keywords => (is => 'rw');
-has match => (is => 'rw');
-has method => (is => 'rw');
-has protocol => (is => 'rw');
+has action => (is => 'rw');
+has address => (is => 'rw');
+has arguments => (is => 'rw', default => sub { [] });
+has cookies => (is => 'rw', default => sub { {} });
+has query_keywords => (is => 'rw');
+has match => (is => 'rw');
+has method => (is => 'rw');
+has protocol => (is => 'rw');
has query_parameters => (is => 'rw', default => sub { {} });
-has secure => (is => 'rw', default => 0);
-has captures => (is => 'rw', default => sub { [] });
-has uri => (is => 'rw');
-has user => (is => 'rw');
-has headers => (
+has secure => (is => 'rw', default => 0);
+has captures => (is => 'rw', default => sub { [] });
+has uri => (is => 'rw');
+has user => (is => 'rw');
+has headers => (
is => 'rw',
isa => 'HTTP::Headers',
handles => [qw(content_encoding content_length content_type header referer user_agent)],
@@ -34,10 +34,10 @@
);
has body_parameters => (
- is => 'rw',
- required => 1,
- lazy => 1,
- default => sub { {} },
+ is => 'rw',
+ required => 1,
+ lazy => 1,
+ default => sub { {} },
);
before body_parameters => sub {
@@ -46,10 +46,10 @@
};
has uploads => (
- is => 'rw',
- required => 1,
- lazy => 1,
- default => sub { {} },
+ is => 'rw',
+ required => 1,
+ lazy => 1,
+ default => sub { {} },
);
before uploads => sub {
@@ -77,14 +77,12 @@
};
has base => (
- is => 'rw',
- required => 1,
- lazy => 1,
- default => sub {
+ is => 'rw',
+ required => 1,
+ lazy => 1,
+ default => sub {
my $self = shift;
- if( $self->uri ){
- return $self->path;
- }
+ return $self->path if $self->uri;
},
);
More information about the Catalyst-commits
mailing list