[Catalyst-commits] r8567 - in trunk/Catalyst-Plugin-Authentication: . t

[t0m at dev.catalyst.perl.org]

Author: t0m
Date: 2008-10-18 17:05:24 +0100 (Sat, 18 Oct 2008)
New Revision: 8567

Modified:
   trunk/Catalyst-Plugin-Authentication/Changes
   trunk/Catalyst-Plugin-Authentication/t/live_app.t
   trunk/Catalyst-Plugin-Authentication/t/live_app_realms.t
   trunk/Catalyst-Plugin-Authentication/t/live_app_realms_compat.t
Log:
Add plans to tests so that aggregate smoke results work correctly. Without a plan, failing to compile the test apps (as happens if you run them against 5.80 trunk currently) doesn't look like a real fail.

Modified: trunk/Catalyst-Plugin-Authentication/Changes
===================================================================
--- trunk/Catalyst-Plugin-Authentication/Changes	2008-10-18 14:01:17 UTC (rev 8566)
+++ trunk/Catalyst-Plugin-Authentication/Changes	2008-10-18 16:05:24 UTC (rev 8567)
@@ -2,6 +2,8 @@
 
 0.1XXX  XXXX
         - Update tests prereqs to include Test::Exception (RT #36339)
+        - Update live tests to have plans, so that smoke tests against
+	  5.80 don't give false positives (t0m)
 
 0.10007_01 2008-06-05
         - Some documentation fixes (including RT #36062)

Modified: trunk/Catalyst-Plugin-Authentication/t/live_app.t
===================================================================
--- trunk/Catalyst-Plugin-Authentication/t/live_app.t	2008-10-18 14:01:17 UTC (rev 8566)
+++ trunk/Catalyst-Plugin-Authentication/t/live_app.t	2008-10-18 16:05:24 UTC (rev 8567)
@@ -1,11 +1,10 @@
 use strict;
 use warnings;
 
-use Test::More;
+use Test::More tests => 1;
 
 BEGIN {
     plan skip_all => "Digest::SHA1 is required for this test" unless eval { require Digest::SHA1 };
-    plan "no_plan";
 }
 
 use lib 't/lib';

Modified: trunk/Catalyst-Plugin-Authentication/t/live_app_realms.t
===================================================================
--- trunk/Catalyst-Plugin-Authentication/t/live_app_realms.t	2008-10-18 14:01:17 UTC (rev 8566)
+++ trunk/Catalyst-Plugin-Authentication/t/live_app_realms.t	2008-10-18 16:05:24 UTC (rev 8567)
@@ -1,12 +1,8 @@
 use strict;
 use warnings;
 
-use Test::More;
+use Test::More tests => 1;
 
-BEGIN {
-    plan "no_plan";
-}
-
 use lib 't/lib';
 use Catalyst::Test qw/AuthRealmTestApp/;
 

Modified: trunk/Catalyst-Plugin-Authentication/t/live_app_realms_compat.t
===================================================================
--- trunk/Catalyst-Plugin-Authentication/t/live_app_realms_compat.t	2008-10-18 14:01:17 UTC (rev 8566)
+++ trunk/Catalyst-Plugin-Authentication/t/live_app_realms_compat.t	2008-10-18 16:05:24 UTC (rev 8567)
@@ -1,12 +1,8 @@
 use strict;
 use warnings;
 
-use Test::More;
+use Test::More tests => 1;
 
-BEGIN {
-    plan "no_plan";
-}
-
 use lib 't/lib';
 use Catalyst::Test qw/AuthRealmTestAppCompat/;