[Catalyst-commits] r8426 - in trunk/Catalyst-Plugin-Session-Store-DBI: . lib/Catalyst/Plugin/Session/Store t

[jhannah at dev.catalyst.perl.org]

Author: jhannah
Date: 2008-09-17 16:02:17 +0100 (Wed, 17 Sep 2008)
New Revision: 8426

Modified:
   trunk/Catalyst-Plugin-Session-Store-DBI/Changes
   trunk/Catalyst-Plugin-Session-Store-DBI/lib/Catalyst/Plugin/Session/Store/DBI.pm
   trunk/Catalyst-Plugin-Session-Store-DBI/t/04critic.t
Log:
Added a POD warning about MySQL TEXT field size. 

Over in Catalyst::Plugin::Session::Store::DBI
I added tests and a warning to catch silent, fatal truncation.
See SVN revision 8425 if the same might apply here. (Jay Hannah)


Modified: trunk/Catalyst-Plugin-Session-Store-DBI/Changes
===================================================================
--- trunk/Catalyst-Plugin-Session-Store-DBI/Changes	2008-09-17 00:22:59 UTC (rev 8425)
+++ trunk/Catalyst-Plugin-Session-Store-DBI/Changes	2008-09-17 15:02:17 UTC (rev 8426)
@@ -1,5 +1,8 @@
 Revision history for Perl extension Catalyst::Plugin::Session::Store::DBI
 
+0.14    2008-09-17 09:53:47
+        - Added a POD warning about MySQL TEXT field size. (Jay Hannah)
+
 0.13    2008-04-29 08:30:00
         - Fixed ping() check to work properly. (Olivier Thauvin)
 

Modified: trunk/Catalyst-Plugin-Session-Store-DBI/lib/Catalyst/Plugin/Session/Store/DBI.pm
===================================================================
--- trunk/Catalyst-Plugin-Session-Store-DBI/lib/Catalyst/Plugin/Session/Store/DBI.pm	2008-09-17 00:22:59 UTC (rev 8425)
+++ trunk/Catalyst-Plugin-Session-Store-DBI/lib/Catalyst/Plugin/Session/Store/DBI.pm	2008-09-17 15:02:17 UTC (rev 8426)
@@ -8,7 +8,7 @@
 use NEXT;
 use Storable qw/nfreeze thaw/;
 
-our $VERSION = '0.13';
+our $VERSION = '0.14';
 
 __PACKAGE__->mk_classdata('_session_sql');
 __PACKAGE__->mk_classdata('_session_dbh');
@@ -414,6 +414,10 @@
 The 'session_data' column should be a long text field.  Session data is
 encoded using Base64 before being stored in the database.
 
+Note that MySQL TEXT fields only store 64KB, so if your session data
+will exceed that size you'll want to move to MEDIUMTEXT, MEDIUMBLOB,
+or larger.
+
 The 'expires' column stores the future expiration time of the session.  This
 may be null for per-user and flash sessions.
 

Modified: trunk/Catalyst-Plugin-Session-Store-DBI/t/04critic.t
===================================================================
--- trunk/Catalyst-Plugin-Session-Store-DBI/t/04critic.t	2008-09-17 00:22:59 UTC (rev 8425)
+++ trunk/Catalyst-Plugin-Session-Store-DBI/t/04critic.t	2008-09-17 15:02:17 UTC (rev 8426)
@@ -11,12 +11,11 @@
 else {
     eval { require Test::Perl::Critic };
     if ( $@ ) {
-        plan tests => 1;
-        fail( 'You must install Test::Perl::Critic to run 04critic.t' );
+        plan skip_all => 'You must install Test::Perl::Critic to run 04critic.t';
         exit;
     }
 }
 
 my $rcfile = File::Spec->catfile( 't', '04critic.rc' );
 Test::Perl::Critic->import( -profile => $rcfile );
-all_critic_ok();
\ No newline at end of file
+all_critic_ok();