[Catalyst-commits] r11223 - Catalyst-Devel/1.00/branches/helper_refactor/lib/Catalyst

[dhoss at dev.catalyst.perl.org]

Author: dhoss
Date: 2009-08-23 21:59:26 +0000 (Sun, 23 Aug 2009)
New Revision: 11223

Modified:
   Catalyst-Devel/1.00/branches/helper_refactor/lib/Catalyst/Helper.pm
Log:
added some notes, and removed $self->_mk_dbic_deploy since it's not going to be default


Modified: Catalyst-Devel/1.00/branches/helper_refactor/lib/Catalyst/Helper.pm
===================================================================
--- Catalyst-Devel/1.00/branches/helper_refactor/lib/Catalyst/Helper.pm	2009-08-23 21:32:35 UTC (rev 11222)
+++ Catalyst-Devel/1.00/branches/helper_refactor/lib/Catalyst/Helper.pm	2009-08-23 21:59:26 UTC (rev 11223)
@@ -112,7 +112,9 @@
         $self->_mk_cgi;
         $self->_mk_fastcgi;
         $self->_mk_server;
-        $self->_mk_dbic_deploy;
+      #  probably want to only do this if a DBIC schema is specified, or move it
+      #  to C::H::Model::DBIC::Schema
+      #  $self->_mk_dbic_deploy; 
         $self->_mk_test;
         $self->_mk_create;
         $self->_mk_information;
@@ -120,6 +122,9 @@
     return $self->{dir};
 }
 
+
+## not much of this can really be changed, mk_compclass must be left for 
+## backcompat
 sub mk_component {
     my $self = shift;
     my $app  = shift;
@@ -190,6 +195,7 @@
                     message => qq/Couldn't load helper "$class", "$@"/ );
             }
 
+            ## must be left for back compat! ###################################
             if ( $class->can('mk_compclass') ) {
                 return 1 unless $class->mk_compclass( $self, @args );
             }
@@ -199,6 +205,7 @@
                 $class->mk_comptest( $self, @args );
             }
             else { $self->_mk_comptest }
+            ####################################################################
         }
 
         # Fallback