[Catalyst-commits] r12225 - in Catalyst-Runtime/5.80/trunk: . t/aggregate

[kmx at dev.catalyst.perl.org]

Author: kmx
Date: 2009-12-06 20:11:43 +0000 (Sun, 06 Dec 2009)
New Revision: 12225

Modified:
   Catalyst-Runtime/5.80/trunk/Changes
   Catalyst-Runtime/5.80/trunk/t/aggregate/utf8_content_length.t
Log:
Win32 fix: reverting commit 12210 (after a discussion with t0m) - all tests pass on Win32/strawberry perl 5.8.9 and 5.10.1

Modified: Catalyst-Runtime/5.80/trunk/Changes
===================================================================
--- Catalyst-Runtime/5.80/trunk/Changes	2009-12-06 19:43:32 UTC (rev 12224)
+++ Catalyst-Runtime/5.80/trunk/Changes	2009-12-06 20:11:43 UTC (rev 12225)
@@ -3,9 +3,6 @@
   Bug fixes:
    - Fix slurping a file to work correctly with binary on Win32 in the
      encoding test controller.
-   - Skip test for outputting the wrong content length when a string
-     which has been utf-8 upgraded is output on Win32 as there is an
-     off by one error somewhere.
    - Allow --restartdirectory as an option for the Server script, for
      backwards compatibility. (Dave Rolsky)
 

Modified: Catalyst-Runtime/5.80/trunk/t/aggregate/utf8_content_length.t
===================================================================
--- Catalyst-Runtime/5.80/trunk/t/aggregate/utf8_content_length.t	2009-12-06 19:43:32 UTC (rev 12224)
+++ Catalyst-Runtime/5.80/trunk/t/aggregate/utf8_content_length.t	2009-12-06 20:11:43 UTC (rev 12225)
@@ -20,13 +20,7 @@
     is $r->code, 200, '/binary OK';
     is $r->header('Content-Length'), $size, '/binary correct content length';
 }
-SKIP: {
-    # Test that even if what is really binary has been upgraded into character
-    # octets in perl, then when we output it we get the correct content length.
-    # The issue was initially described in the thread 'Avoiding UTF8 in
-    # Catalyst': http://lists.scsys.co.uk/pipermail/catalyst/2009-November/023912.html.
-    # FIXME! (See ml thread re 5.80015 release)
-    skip 'Known not to work on Win32', 2 if ($^O eq 'MSWin32');
+{
     my $r = request('/binary_utf8');
     is $r->code, 200, '/binary_utf8 OK';
     is $r->header('Content-Length'), $size, '/binary_utf8 correct content length';