[Catalyst-commits] r9176 - Catalyst-Runtime/5.80/trunk/lib/Catalyst

[rafl at dev.catalyst.perl.org]

Author: rafl
Date: 2009-02-03 09:44:54 +0000 (Tue, 03 Feb 2009)
New Revision: 9176

Modified:
   Catalyst-Runtime/5.80/trunk/lib/Catalyst/Upgrading.pod
Log:
Document the issues with overriding setup in Upgrading.pod.

Modified: Catalyst-Runtime/5.80/trunk/lib/Catalyst/Upgrading.pod
===================================================================
--- Catalyst-Runtime/5.80/trunk/lib/Catalyst/Upgrading.pod	2009-02-03 08:16:46 UTC (rev 9175)
+++ Catalyst-Runtime/5.80/trunk/lib/Catalyst/Upgrading.pod	2009-02-03 09:44:54 UTC (rev 9176)
@@ -77,6 +77,32 @@
     my $metaclass = Moose::Meta::Class->initialize($package_name);
     $metaclass->add_method($method_name => sub { ... });
 
+=head2 Hooking into application setup
+
+To execute code during application startup the following snippet in MyApp.pm
+used to work:
+
+    sub setup {
+        my ($class, @args) = @_;
+        $class->NEXT::setup(@args);
+        ... # things to do after the actual setup
+    }
+
+With Catalyst 5.80 this won't work anymore. Because instead of using NEXT.pm it
+relies on Class::C3::Adopt::NEXT, which doesn't remember what methods it
+already called, like NEXT does and therefore goes into a deep recursion between
+MyApp::setup and Catalyst::setup.
+
+Moose method modifiers line C<< before|after|around 'setup => sub { ... }; >>
+won't work either because of backward compatibility issues related to plugin
+setup methods.
+
+The right way to do it is this:
+
+    after setup_finalize => sub {
+        ... # things to do after the actual setup
+    };
+
 =head2 Components whos new method returns false
 
 Previously if your new method returned a false value,