[Catalyst-commits] r9035 - in Catalyst-Runtime/5.80/trunk: . lib/Catalyst

[t0m at dev.catalyst.perl.org]

Author: t0m
Date: 2009-01-07 23:25:06 +0000 (Wed, 07 Jan 2009)
New Revision: 9035

Modified:
   Catalyst-Runtime/5.80/trunk/Makefile.PL
   Catalyst-Runtime/5.80/trunk/TODO
   Catalyst-Runtime/5.80/trunk/lib/Catalyst/Upgrading.pod
Log:
CX::Imports, TODO updates, note mst rant, add some docs

Modified: Catalyst-Runtime/5.80/trunk/Makefile.PL
===================================================================
--- Catalyst-Runtime/5.80/trunk/Makefile.PL	2009-01-07 23:24:56 UTC (rev 9034)
+++ Catalyst-Runtime/5.80/trunk/Makefile.PL	2009-01-07 23:25:06 UTC (rev 9035)
@@ -126,6 +126,7 @@
 sub check_conflicts {
     my %conflicts = (
         'Catalyst::Plugin::Authentication' => '0.100092',
+        'CatalystX::Imports' => '0.03',
     );
 
     my $found = 0;

Modified: Catalyst-Runtime/5.80/trunk/TODO
===================================================================
--- Catalyst-Runtime/5.80/trunk/TODO	2009-01-07 23:24:56 UTC (rev 9034)
+++ Catalyst-Runtime/5.80/trunk/TODO	2009-01-07 23:25:06 UTC (rev 9035)
@@ -9,14 +9,12 @@
 
 Known issues:
      - CatalystX-Imports, Class::MOP doesn't consider anon subs in the symbol 
-       table as methods, tests + fix, or explanation and documentation?
-       (rafl & phaylon)
- 
+       table as methods, new version of fixed plugin (rafl), explanation of 
+       the issue in Catalyst::Upgrading (groditi)
+       
      - Catalyst-Log-Log4perl Deep recursion on subroutine "MockApp::setup" 
        (rafl)
-     
-     - Catalyst-Plugin-Cache dies due to mk_accessors('meta')
-     
+
      - CatalystX-CRUD and CatalystX-CRUD-ModelAdapter-DBIC
        fail tests against 5.80 (karpet)
 
@@ -33,6 +31,13 @@
 
 Cleanups:
 
+18:01 <@mst> hmm. I think that warning should show what it found
+18:01 <@mst> and say "you probably called ->model("Sessions") when you meant ->model("DB::Sessions")" or whatever
+18:05 <@mst> unsafe_component_use_ok
+18:05 <@mst> like we did for BindLex
+
+
+
   - Update Test suite to not assume MyApp ISA Controller
     - After that set up attr handlers that will output helpful error messages 
       when you do it as well as how to fix it.
@@ -68,8 +73,6 @@
 Tests:
 
   - Moosified test application?
-
-  - Test & document warnings from back-compat methods in Catalyst::Dispatcher
   
   - Test & document warnings from plugin method on Catalyst
 

Modified: Catalyst-Runtime/5.80/trunk/lib/Catalyst/Upgrading.pod
===================================================================
--- Catalyst-Runtime/5.80/trunk/lib/Catalyst/Upgrading.pod	2009-01-07 23:24:56 UTC (rev 9034)
+++ Catalyst-Runtime/5.80/trunk/lib/Catalyst/Upgrading.pod	2009-01-07 23:25:06 UTC (rev 9035)
@@ -79,13 +79,41 @@
 to perform any construction work necessary for your sub-class.
 
 
-=head Methods in Catalyst::Dispatcher
+=head1 WARNINGS
 
+=head2 Methods in Catalyst::Dispatcher
+
+The following methods in Catalyst::Dispatcher are likely to change 
+significantly in the 5.8X release series, and therefore their use is highly
+deprecated.
+
+=over
+
+=item tree 
+
+=item dispatch_types 
+
+=item registered_dispatch_types 
+
+=item method_action_class  
+
+=item action_hash 
+
+=item container_hash
+
+=back
+
+The first time one of these methods is called, a warning will be emitted:
+
     Class $class is calling the deprecated method Catalyst::Dispatcher::$public_method_name,\n"
     . "this will be removed in Catalyst 5.9X"
 
-FIXME
+You should B<NEVER> be calling any of these methods from application code.
 
+Plugins authors and maintainers whos plugins need to call these methods 
+should email the development list to discuss your use-case, and what a 
+better API should look like.
+
 =head2 Confused multiple inheritence with Catalyst::Component::COMPONENT
 
 Warning message: