[Catalyst-commits] r10579 - Catalyst-Runtime/5.80/trunk/t

[t0m at dev.catalyst.perl.org]

Author: t0m
Date: 2009-06-18 01:21:17 +0000 (Thu, 18 Jun 2009)
New Revision: 10579

Modified:
   Catalyst-Runtime/5.80/trunk/t/unit_core_uri_for.t
Log:
Test dinks

Modified: Catalyst-Runtime/5.80/trunk/t/unit_core_uri_for.t
===================================================================
--- Catalyst-Runtime/5.80/trunk/t/unit_core_uri_for.t	2009-06-17 22:30:00 UTC (rev 10578)
+++ Catalyst-Runtime/5.80/trunk/t/unit_core_uri_for.t	2009-06-18 01:21:17 UTC (rev 10579)
@@ -1,7 +1,7 @@
 use strict;
 use warnings;
 
-use Test::More tests => 17;
+use Test::More tests => 18;
 use URI;
 
 use_ok('Catalyst');
@@ -108,18 +108,22 @@
     'http://127.0.0.1/foo/bar', 'uri is /foo/bar, not //foo/bar'
 );
 
-if ( 0 ) {
+TODO: {
+    local $TODO = 'RFCs are for people who, erm - fix this test..';
     # Test rfc3986 reserved characters.  These characters should all be escaped
     # according to the RFC, but it is a very big feature change so I've removed it
-    is( 
-        Catalyst::uri_for( $context, qw|! * ' ( ) ; : @ & = $ , / ? % # [ ]| )->as_string,
+    no warnings; # Yes, everything in qw is sane
+    is(
+        Catalyst::uri_for( $context, qw|! * ' ( ) ; : @ & = $ / ? % # [ ] ,|, )->as_string,
         'http://127.0.0.1/%21/%2A/%27/%2B/%29/%3B/%3A/%40/%26/%3D/%24/%2C/%2F/%3F/%25/%23/%5B/%5D',
         'rfc 3986 reserved characters'
     );
 }
 
-is( 
+# jshirley bug t0m fucked in r10097
+is(
     Catalyst::uri_for( $context, qw|{1} {2}| )->as_string,
     'http://127.0.0.1/{1}/{2}',
     'not-escaping unreserved characters'
 );
+